Skip to content

Commit af365c9

Browse files
authored
Make FilesystemRadio serialize monitoring messages the same as UDP and HTEX radios (#3679)
UDP and HTEX radios both use pickle, not parsl.serialize, and there is no reason for this inconsistency. ## Type of change - Code maintenance/cleanup
1 parent ad9533b commit af365c9

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

parsl/monitoring/monitoring.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import logging
44
import multiprocessing.synchronize as ms
55
import os
6+
import pickle
67
import queue
78
import time
89
from multiprocessing import Event, Process
@@ -18,7 +19,6 @@
1819
from parsl.monitoring.types import TaggedMonitoringMessage
1920
from parsl.multiprocessing import ForkProcess, SizedQueue
2021
from parsl.process_loggers import wrap_with_logs
21-
from parsl.serialize import deserialize
2222
from parsl.utils import RepresentationMixin, setproctitle
2323

2424
_db_manager_excepts: Optional[Exception]
@@ -282,7 +282,7 @@ def filesystem_receiver(logdir: str, q: "queue.Queue[TaggedMonitoringMessage]",
282282
logger.info("Processing filesystem radio file %s", filename)
283283
full_path_filename = f"{new_dir}/{filename}"
284284
with open(full_path_filename, "rb") as f:
285-
message = deserialize(f.read())
285+
message = pickle.load(f)
286286
logger.debug("Message received is: %s", message)
287287
assert isinstance(message, tuple)
288288
q.put(cast(TaggedMonitoringMessage, message))

parsl/monitoring/radios.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
import zmq
1010

11-
from parsl.serialize import serialize
12-
1311
logger = logging.getLogger(__name__)
1412

1513

@@ -59,7 +57,7 @@ def send(self, message: object) -> None:
5957
# move it into new/, so that a partially written
6058
# file will never be observed in new/
6159
with open(tmp_filename, "wb") as f:
62-
f.write(serialize(buffer))
60+
pickle.dump(buffer, f)
6361
os.rename(tmp_filename, new_filename)
6462

6563

0 commit comments

Comments
 (0)