Skip to content

Commit b7cd9a4

Browse files
committed
this is only called in one place - where it is called is also modifying internal structures, so do the modification explicitly.
1 parent 89cf2d7 commit b7cd9a4

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

parsl/executors/status_handling.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,6 @@ def status_polling_interval(self):
104104
else:
105105
return self._provider.status_polling_interval
106106

107-
def _fail_job_async(self, block_id: str, message: str):
108-
"""Marks a job that has failed to start but would not otherwise be included in status()
109-
as failed and report it in status()
110-
"""
111-
self._simulated_status[block_id] = JobStatus(JobState.FAILED, message)
112-
113107
@abstractproperty
114108
def outstanding(self) -> int:
115109
"""This should return the number of tasks that the executor has been given to run (waiting to run, and running now)"""
@@ -200,8 +194,7 @@ def scale_out(self, blocks: int = 1) -> List[str]:
200194
self.job_ids_to_block[job_id] = block_id
201195
block_ids.append(block_id)
202196
except Exception as ex:
203-
self._fail_job_async(block_id,
204-
"Failed to start block {}: {}".format(block_id, ex))
197+
self._simulated_status[block_id] = JobStatus(JobState.FAILED, "Failed to start block {}: {}".format(block_id, ex))
205198
return block_ids
206199

207200
@abstractmethod

0 commit comments

Comments
 (0)