Skip to content

Commit cdc4445

Browse files
authored
Rename misnamed dependency launch thread (#4012)
While the original work which introduced this (PR #3478) was aimed at fixing a stack depth bug to do with dependency task launches, this thread is actually used for *all* task launches. # Changed Behaviour thread name in log file will be new name ## Type of change - Update to human readable text: Documentation/error messages/comments
1 parent 0f6496e commit cdc4445

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

parsl/dataflow/dflow.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def __init__(self, config: Config) -> None:
190190
self.tasks: Dict[int, TaskRecord] = {}
191191
self.submitter_lock = threading.Lock()
192192

193-
self.dependency_launch_pool = cf.ThreadPoolExecutor(max_workers=1, thread_name_prefix="Dependency-Launch")
193+
self._task_launch_pool = cf.ThreadPoolExecutor(max_workers=1, thread_name_prefix="Task-Launch")
194194

195195
self.dependency_resolver = self.config.dependency_resolver if self.config.dependency_resolver is not None \
196196
else SHALLOW_DEPENDENCY_RESOLVER
@@ -608,7 +608,7 @@ def launch_if_ready(self, task_record: TaskRecord) -> None:
608608
launch_if_ready is thread safe, so may be called from any thread
609609
or callback.
610610
"""
611-
self.dependency_launch_pool.submit(self._launch_if_ready_async, task_record)
611+
self._task_launch_pool.submit(self._launch_if_ready_async, task_record)
612612

613613
@wrap_with_logs
614614
def _launch_if_ready_async(self, task_record: TaskRecord) -> None:
@@ -1203,9 +1203,9 @@ def cleanup(self) -> None:
12031203
self.monitoring.close()
12041204
logger.info("Terminated monitoring")
12051205

1206-
logger.info("Terminating dependency launch pool")
1207-
self.dependency_launch_pool.shutdown()
1208-
logger.info("Terminated dependency launch pool")
1206+
logger.info("Terminating task launch pool")
1207+
self._task_launch_pool.shutdown()
1208+
logger.info("Terminated task launch pool")
12091209

12101210
logger.info("Unregistering atexit hook")
12111211
atexit.unregister(self.atexit_cleanup)

0 commit comments

Comments
 (0)