Skip to content

Commit ea8fee9

Browse files
committed
close method for api
1 parent 7a71c7e commit ea8fee9

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

parsl/dataflow/dflow.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,6 +1190,7 @@ def cleanup(self) -> None:
11901190

11911191
self.log_task_states()
11921192

1193+
# TODO: do this in the basic memoizer
11931194
# Checkpointing takes priority over the rest of the tasks
11941195
# checkpoint if any valid checkpoint method is specified
11951196
if self.checkpoint_mode is not None:
@@ -1202,6 +1203,10 @@ def cleanup(self) -> None:
12021203
logger.info("Stopping checkpoint timer")
12031204
self._checkpoint_timer.close()
12041205

1206+
logger.info("Closing memoizer")
1207+
self.memoizer.close()
1208+
logger.info("Closed memoizer")
1209+
12051210
# Send final stats
12061211
self.usage_tracker.send_end_message()
12071212
self.usage_tracker.close()

parsl/dataflow/memoization.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,9 @@ def checkpoint(self, tasks: Sequence[TaskRecord]) -> None:
130130
def check_memo(self, task: TaskRecord) -> Optional[Future[Any]]:
131131
raise NotImplementedError
132132

133+
def close(self) -> None:
134+
raise NotImplementedError
135+
133136

134137
class BasicMemoizer(Memoizer):
135138
"""Memoizer is responsible for ensuring that identical work is not repeated.

0 commit comments

Comments
 (0)