Skip to content

Commit fae179c

Browse files
authored
Reduce SizedQueue to a regular Queue in monitoring radios (#3936)
The radios do not make use of the .qsize() functionality of queues, and so th (broken, see #3856) platform-specific sized queue functionality is not necessary. This is part of a series of PRs to remove that platform-specific functionality entirely - see PR #3932. # Changed Behaviour This code is part of broken behaviour on Macs. The behaviour will be slightly better but still broken after this PR on that platform. Otherwise, the queue should not behave any differently. ## Type of change - Code maintenance/cleanup
1 parent 0b9cd5b commit fae179c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

parsl/monitoring/radios/udp_router.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
from parsl.monitoring.radios.base import MonitoringRadioReceiver
2222
from parsl.monitoring.radios.multiprocessing import MultiprocessingQueueRadioSender
2323
from parsl.multiprocessing import (
24-
SizedQueue,
2524
SpawnEvent,
2625
SpawnProcess,
26+
SpawnQueue,
2727
join_terminate_close_proc,
2828
)
2929
from parsl.process_loggers import wrap_with_logs
@@ -198,7 +198,7 @@ def start_udp_receiver(*,
198198
hmac_digest: str) -> UDPRadioReceiver:
199199

200200
udp_comm_q: Queue[Union[int, str]]
201-
udp_comm_q = SizedQueue(maxsize=10)
201+
udp_comm_q = SpawnQueue(maxsize=10)
202202

203203
router_exit_event = SpawnEvent()
204204

parsl/monitoring/radios/zmq_router.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
from parsl.monitoring.radios.multiprocessing import MultiprocessingQueueRadioSender
2020
from parsl.monitoring.types import TaggedMonitoringMessage
2121
from parsl.multiprocessing import (
22-
SizedQueue,
2322
SpawnEvent,
2423
SpawnProcess,
24+
SpawnQueue,
2525
join_terminate_close_proc,
2626
)
2727
from parsl.process_loggers import wrap_with_logs
@@ -158,7 +158,7 @@ def start_zmq_receiver(*,
158158
port_range: Tuple[int, int],
159159
logdir: str,
160160
worker_debug: bool) -> ZMQRadioReceiver:
161-
comm_q = SizedQueue(maxsize=10)
161+
comm_q = SpawnQueue(maxsize=10)
162162

163163
router_exit_event = SpawnEvent()
164164

0 commit comments

Comments
 (0)