Skip to content

Commit fc05583

Browse files
authored
Remove special-case checkpoint case from garbage collector test (#3976)
Prior to PR #2514, tasks were removed at checkpoint-completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue. # Changed Behaviour none ## Type of change - Code maintenance/cleanup
1 parent dc4a9eb commit fc05583

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

parsl/tests/test_python_apps/test_garbage_collect.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,5 @@ def test_garbage_collect():
2727

2828
evt.set()
2929
assert x.result() == 10 * 4
30-
if parsl.dfk().checkpoint_mode is not None:
31-
# We explicit call checkpoint if checkpoint_mode is enabled covering
32-
# cases like manual/periodic where checkpointing may be deferred.
33-
parsl.dfk().checkpoint()
34-
35-
time.sleep(0.01) # Give enough time for task wipes to work
30+
time.sleep(0.01) # Give enough time for task wipes to work - see issue #1279
3631
assert x.tid not in parsl.dfk().tasks, "Task record should be wiped after task completion"

0 commit comments

Comments
 (0)