-
Notifications
You must be signed in to change notification settings - Fork 211
TaskVine executor: add parsl serialize module to default library context #3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This needs cctools 7.13.0 (because thats the first release that has hoisting_modules) but I noticed that Parsl CI is still on 7.8.0 so I think there isn't any test coverage for this change. |
|
I tried this out on my laptop with serverless mode turned on: a pytest run reduces from 116 seconds to 20 seconds. So it would be good for timing considerations to switch our CI taskvine test over to this mode, perhaps. and goes from Importing So I propose that importing plain I'm a little unclear what happens for user code that would benefit from this kind of pre-load for other modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see other comments
|
@benclifford thoughts on getting this merged? Is |
@dthain yes |
|
Closing in favor of #3902 |
…ext (#3902) # Description This improves task throughput for taskvine serverless by caching the serialize module and base function definition in the library. # Changed Behaviour All workflows using TaskVine # Fixes Minor update to PR #3604 ## Type of change Choose which options apply, and delete the ones which do not apply. - Performance improvement FYI @colinthomas-z80 @benclifford --------- Co-authored-by: Ben Clifford <[email protected]>
Description
This improves task throughput for taskvine serverless by caching the serialize module and base function definition in the library
Type of change
Choose which options apply, and delete the ones which do not apply.