Replace hardcoded entity type names with synonym placeholders in English and German translations (#1128)

* Initial plan

* Initial plan for replacing entity type names with placeholders

Co-authored-by: jbtronics <[email protected]>

* Replace entity type names with synonym placeholders in English translations

Co-authored-by: jbtronics <[email protected]>

* Add more synonym placeholders for storage location, project, and part patterns

Co-authored-by: jbtronics <[email protected]>

* Update tree navigation labels with synonym placeholders

Co-authored-by: jbtronics <[email protected]>

* Fix remaining entity type placeholders identified in code review

Co-authored-by: jbtronics <[email protected]>

* Fix placeholder syntax: use [Type]/[[Type]] instead of {type}/{{type}} and add German translations

Co-authored-by: jbtronics <[email protected]>

* Fix German translation to avoid awkward word concatenation with placeholder

Co-authored-by: jbtronics <[email protected]>

* Use capitalized placeholders in German translations (nouns are always capitalized in German)

Co-authored-by: jbtronics <[email protected]>

* Fixed length menu for datatable views

* Capitalize placeholders at the beginning of sentences/titles in English translations

Co-authored-by: jbtronics <[email protected]>

* Ensure that synonym placeholders get cached on a per locale level

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jbtronics <[email protected]>
Co-authored-by: Jan Böhmer <[email protected]>

Author: Copilot

src/EventListener/RegisterSynonymsAsTranslationParametersListener.php

@@ -50,9 +50,9 @@ public function __construct(
         $this->translator = $translator;
     }
 
-    public function getSynonymPlaceholders(): array
+    public function getSynonymPlaceholders(string $locale): array
     {
-        return $this->cache->get('partdb_synonym_placeholders', function (ItemInterface $item) {
+        return $this->cache->get('partdb_synonym_placeholders' . '_' . $locale, function (ItemInterface $item) use ($locale) {
             $item->tag('synonyms');
 
 
@@ -62,12 +62,12 @@ public function getSynonymPlaceholders(): array
             foreach (ElementTypes::cases() as $elementType) {
                 //Versions with capitalized first letter
                 $capitalized = ucfirst($elementType->value); //We have only ASCII element type values, so this is sufficient
-                $placeholders['[' . $capitalized . ']'] = $this->typeNameGenerator->typeLabel($elementType);
-                $placeholders['[[' . $capitalized . ']]'] = $this->typeNameGenerator->typeLabelPlural($elementType);
+                $placeholders['[' . $capitalized . ']'] = $this->typeNameGenerator->typeLabel($elementType, $locale);
+                $placeholders['[[' . $capitalized . ']]'] = $this->typeNameGenerator->typeLabelPlural($elementType, $locale);
 
                 //And we have lowercase versions for both
-                $placeholders['[' . $elementType->value . ']'] = mb_strtolower($this->typeNameGenerator->typeLabel($elementType));
-                $placeholders['[[' . $elementType->value . ']]'] = mb_strtolower($this->typeNameGenerator->typeLabelPlural($elementType));
+                $placeholders['[' . $elementType->value . ']'] = mb_strtolower($this->typeNameGenerator->typeLabel($elementType, $locale));
+                $placeholders['[[' . $elementType->value . ']]'] = mb_strtolower($this->typeNameGenerator->typeLabelPlural($elementType, $locale));
             }
 
             return $placeholders;
@@ -82,7 +82,7 @@ public function __invoke(RequestEvent $event): void
         }
 
         //Register all placeholders for synonyms
-        $placeholders = $this->getSynonymPlaceholders();
+        $placeholders = $this->getSynonymPlaceholders($event->getRequest()->getLocale());
         foreach ($placeholders as $key => $value) {
             $this->translator->addGlobalParameter($key, $value);
         }

tests/EventListener/RegisterSynonymsAsTranslationParametersTest.php

@@ -37,7 +37,7 @@ public function setUp(): void
 
     public function testGetSynonymPlaceholders(): void
     {
-        $placeholders = $this->listener->getSynonymPlaceholders();
+        $placeholders = $this->listener->getSynonymPlaceholders('en');
 
         $this->assertIsArray($placeholders);
         // Curly braces for lowercase versions

translations/messages.cs.xlf

@@ -13495,5 +13495,14 @@ Vezměte prosím na vědomí, že se nemůžete vydávat za uživatele se zakáz
         <target>Uživatelé</target>
       </segment>
     </unit>
+        <unit id="MxKRRx_" name="datatable.datatable.lengthMenu">
+            <notes>
+                <note priority="1">Do not remove! Used for datatables rendering.</note>
+            </notes>
+            <segment state="translated">
+                <source>datatable.datatable.lengthMenu</source>
+                <target>_MENU_</target>
+              </segment>
+        </unit>
   </file>
-</xliff>
+</xliff>

translations/messages.da.xlf

@@ -12164,5 +12164,14 @@ Bemærk venligst, at du ikke kan kopiere fra deaktiveret bruger. Hvis du prøver
         <target>Brugere</target>
       </segment>
     </unit>
+    <unit id="MxKRRx_" name="datatable.datatable.lengthMenu">
+        <notes>
+            <note priority="1">Do not remove! Used for datatables rendering.</note>
+        </notes>
+        <segment state="translated">
+            <source>datatable.datatable.lengthMenu</source>
+            <target>_MENU_</target>
+          </segment>
+    </unit>
   </file>
-</xliff>
+</xliff>