Fixed problem with undeleting elements containing an embedded and propertly restore the infos of the embed

This fixes issue #685

Author: jbtronics

src/Services/LogSystem/TimeTravel.php

@@ -216,15 +216,23 @@ public function applyEntry(AbstractDBElement $element, TimeTravelInterface $logE
         $old_data = $logEntry->getOldData();
 
         foreach ($old_data as $field => $data) {
-            if ($metadata->hasField($field)) {
+
+            //We use the fieldMappings property directly instead of the hasField method, as we do not want to match the embedded field itself
+            //The sub fields are handled in the setField method
+            if (isset($metadata->fieldMappings[$field])) {
                 //We need to convert the string to a BigDecimal first
                 if (!$data instanceof BigDecimal && ('big_decimal' === $metadata->getFieldMapping($field)->type)) {
                     $data = BigDecimal::of($data);
                 }
 
                 if (!$data instanceof \DateTimeInterface
                     && (in_array($metadata->getFieldMapping($field)->type,
-                        [Types::DATETIME_IMMUTABLE, Types::DATETIME_IMMUTABLE, Types::DATE_MUTABLE, Types::DATETIME_IMMUTABLE], true))) {
+                        [
+                            Types::DATETIME_IMMUTABLE,
+                            Types::DATETIME_IMMUTABLE,
+                            Types::DATE_MUTABLE,
+                            Types::DATETIME_IMMUTABLE
+                        ], true))) {
                     $data = $this->dateTimeDecode($data, $metadata->getFieldMapping($field)->type);
                 }
 
@@ -267,9 +275,11 @@ protected function setField(AbstractDBElement $element, string $field, mixed $ne
 
             $embeddedReflection = new ReflectionClass($embeddedClass::class);
             $property = $embeddedReflection->getProperty($embedded_field);
+            $target_element = $embeddedClass;
         } else {
             $reflection = new ReflectionClass($element::class);
             $property = $reflection->getProperty($field);
+            $target_element = $element;
         }
 
         //Check if the property is an BackedEnum, then convert the int or float value to an enum instance
@@ -281,6 +291,6 @@ protected function setField(AbstractDBElement $element, string $field, mixed $ne
             $new_value = $enum_class::from($new_value);
         }
 
-        $property->setValue($element, $new_value);
+        $property->setValue($target_element, $new_value);
     }
 }