Fixed "implicitly marking parameter as nullable" deprecations in PHP 8.4 fixed

jbtronics · jbtronics · commit b724b05de640 · 2025-02-08T00:19:20.000+01:00
diff --git a/src/ApiPlatform/AddDocumentedAPIPropertiesJSONSchemaFactory.php b/src/ApiPlatform/AddDocumentedAPIPropertiesJSONSchemaFactory.php
@@ -43,9 +43,9 @@ public function buildSchema(
         string $className,
         string $format = 'json',
         string $type = Schema::TYPE_OUTPUT,
-        Operation $operation = null,
-        Schema $schema = null,
-        array $serializerContext = null,
+        ?Operation $operation = null,
+        ?Schema $schema = null,
+        ?array $serializerContext = null,
         bool $forceCollection = false
     ): Schema {
 
diff --git a/src/ApiPlatform/Filter/EntityFilter.php b/src/ApiPlatform/Filter/EntityFilter.php
@@ -37,7 +37,7 @@ class EntityFilter extends AbstractFilter
     public function __construct(
         ManagerRegistry $managerRegistry,
         private readonly EntityFilterHelper $filter_helper,
-        LoggerInterface $logger = null,
+        ?LoggerInterface $logger = null,
         ?array $properties = null,
         ?NameConverterInterface $nameConverter = null
     ) {
@@ -50,7 +50,7 @@ protected function filterProperty(
         QueryBuilder $queryBuilder,
         QueryNameGeneratorInterface $queryNameGenerator,
         string $resourceClass,
-        Operation $operation = null,
+        ?Operation $operation = null,
         array $context = []
     ): void {
         if (
diff --git a/src/ApiPlatform/Filter/LikeFilter.php b/src/ApiPlatform/Filter/LikeFilter.php
@@ -38,7 +38,7 @@ protected function filterProperty(
         QueryBuilder $queryBuilder,
         QueryNameGeneratorInterface $queryNameGenerator,
         string $resourceClass,
-        Operation $operation = null,
+        ?Operation $operation = null,
         array $context = []
     ): void {
         // Otherwise filter is applied to order and page as well
diff --git a/src/ApiPlatform/Filter/PartStoragelocationFilter.php b/src/ApiPlatform/Filter/PartStoragelocationFilter.php
@@ -38,7 +38,7 @@ class PartStoragelocationFilter extends AbstractFilter
     public function __construct(
         ManagerRegistry $managerRegistry,
         private readonly EntityFilterHelper $filter_helper,
-        LoggerInterface $logger = null,
+        ?LoggerInterface $logger = null,
         ?array $properties = null,
         ?NameConverterInterface $nameConverter = null
     ) {
@@ -51,7 +51,7 @@ protected function filterProperty(
         QueryBuilder $queryBuilder,
         QueryNameGeneratorInterface $queryNameGenerator,
         string $resourceClass,
-        Operation $operation = null,
+        ?Operation $operation = null,
         array $context = []
     ): void {
         //Do not check for mapping here, as we are using a virtual property
diff --git a/src/Command/User/UserEnableCommand.php b/src/Command/User/UserEnableCommand.php
@@ -35,7 +35,7 @@
 #[AsCommand('partdb:users:enable|partdb:user:enable', 'Enables/Disable the login of one or more users')]
 class UserEnableCommand extends Command
 {
-    public function __construct(protected EntityManagerInterface $entityManager, string $name = null)
+    public function __construct(protected EntityManagerInterface $entityManager, ?string $name = null)
     {
         parent::__construct($name);
     }
diff --git a/src/DataTables/Adapters/TwoStepORMAdapter.php b/src/DataTables/Adapters/TwoStepORMAdapter.php
@@ -54,7 +54,7 @@ class TwoStepORMAdapter extends ORMAdapter
 
     private \Closure|null $query_modifier = null;
 
-    public function __construct(ManagerRegistry $registry = null)
+    public function __construct(?ManagerRegistry $registry = null)
     {
         parent::__construct($registry);
         $this->detailQueryCallable = static function (QueryBuilder $qb, array $ids): never {
diff --git a/src/DataTables/Filters/Constraints/AbstractConstraint.php b/src/DataTables/Filters/Constraints/AbstractConstraint.php
@@ -45,7 +45,7 @@ public function __construct(
      * @var string The property where this BooleanConstraint should apply to
      */
     protected string $property,
-    string $identifier = null)
+    ?string $identifier = null)
     {
         $this->identifier = $identifier ?? $this->generateParameterIdentifier($property);
     }
diff --git a/src/DataTables/Filters/Constraints/BooleanConstraint.php b/src/DataTables/Filters/Constraints/BooleanConstraint.php
@@ -28,7 +28,7 @@ class BooleanConstraint extends AbstractConstraint
 {
     public function __construct(
         string $property,
-        string $identifier = null,
+        ?string $identifier = null,
         /** @var bool|null The value of our constraint */
         protected ?bool $value = null
     )
diff --git a/src/DataTables/Filters/Constraints/DateTimeConstraint.php b/src/DataTables/Filters/Constraints/DateTimeConstraint.php
@@ -34,7 +34,7 @@ class DateTimeConstraint extends AbstractConstraint
 
     public function __construct(
         string $property,
-        string $identifier = null,
+        ?string $identifier = null,
         /**
          * The value1 used for comparison (this is the main one used for all mono-value comparisons)
          */
diff --git a/src/DataTables/Filters/Constraints/EntityConstraint.php b/src/DataTables/Filters/Constraints/EntityConstraint.php
@@ -46,7 +46,7 @@ class EntityConstraint extends AbstractConstraint
     public function __construct(protected ?NodesListBuilder $nodesListBuilder,
         protected string $class,
         string $property,
-        string $identifier = null,
+        ?string $identifier = null,
         protected ?AbstractDBElement $value = null,
         protected ?string $operator = null)
     {
diff --git a/src/DataTables/Filters/Constraints/NumberConstraint.php b/src/DataTables/Filters/Constraints/NumberConstraint.php
@@ -31,7 +31,7 @@ class NumberConstraint extends AbstractConstraint
 
     public function __construct(
         string $property,
-        string $identifier = null,
+        ?string $identifier = null,
         /**
          * The value1 used for comparison (this is the main one used for all mono-value comparisons)
          */
diff --git a/src/DataTables/Filters/Constraints/Part/LessThanDesiredConstraint.php b/src/DataTables/Filters/Constraints/Part/LessThanDesiredConstraint.php
@@ -28,7 +28,7 @@
 
 class LessThanDesiredConstraint extends BooleanConstraint
 {
-    public function __construct(string $property = null, string $identifier = null, ?bool $default_value = null)
+    public function __construct(?string $property = null, ?string $identifier = null, ?bool $default_value = null)
     {
         parent::__construct($property ?? '(
                     SELECT COALESCE(SUM(ld_partLot.amount), 0.0)
diff --git a/src/DataTables/Filters/Constraints/Part/TagsConstraint.php b/src/DataTables/Filters/Constraints/Part/TagsConstraint.php
@@ -30,7 +30,7 @@ class TagsConstraint extends AbstractConstraint
 {
     final public const ALLOWED_OPERATOR_VALUES = ['ANY', 'ALL', 'NONE'];
 
-    public function __construct(string $property, string $identifier = null,
+    public function __construct(string $property, ?string $identifier = null,
         protected ?string $value = null,
         protected ?string $operator = '')
     {
diff --git a/src/DataTables/Filters/Constraints/TextConstraint.php b/src/DataTables/Filters/Constraints/TextConstraint.php
@@ -32,7 +32,7 @@ class TextConstraint extends AbstractConstraint
     /**
      * @param string $value
      */
-    public function __construct(string $property, string $identifier = null, /**
+    public function __construct(string $property, ?string $identifier = null, /**
      * @var string|null The value to compare to
      */
     protected ?string $value = null, /**
diff --git a/src/Entity/Base/AbstractCompany.php b/src/Entity/Base/AbstractCompany.php
@@ -162,7 +162,7 @@ public function getWebsite(): string
      *
      * @return string the link to the article
      */
-    public function getAutoProductUrl(string $partnr = null): string
+    public function getAutoProductUrl(?string $partnr = null): string
     {
         if (is_string($partnr)) {
             return str_replace('%PARTNUMBER%', $partnr, $this->auto_product_url);
diff --git a/src/Entity/OAuthToken.php b/src/Entity/OAuthToken.php
@@ -54,7 +54,7 @@ class OAuthToken extends AbstractNamedDBElement implements AccessTokenInterface
      */
     private const DEFAULT_EXPIRATION_TIME = 3600;
 
-    public function __construct(string $name, ?string $refresh_token, ?string $token = null, \DateTimeImmutable $expires_at = null)
+    public function __construct(string $name, ?string $refresh_token, ?string $token = null, ?\DateTimeImmutable $expires_at = null)
     {
         //If token is given, you also have to give the expires_at date
         if ($token !== null && $expires_at === null) {
diff --git a/src/Migration/WithPermPresetsTrait.php b/src/Migration/WithPermPresetsTrait.php
@@ -62,7 +62,7 @@ public function getPermissions(): PermissionData
         return json_encode($user->getPermissions());
     }
 
-    public function setContainer(ContainerInterface $container = null): void
+    public function setContainer(?ContainerInterface $container = null): void
     {
         if ($container !== null) {
             $this->container = $container;
diff --git a/src/Repository/LogEntryRepository.php b/src/Repository/LogEntryRepository.php
@@ -160,7 +160,7 @@ public function getElementExistedAtTimestamp(AbstractDBElement $element, \DateTi
      * @param  int|null  $limit
      * @param  int|null  $offset
      */
-    public function getLogsOrderedByTimestamp(string $order = 'DESC', int $limit = null, int $offset = null): array
+    public function getLogsOrderedByTimestamp(string $order = 'DESC', ?int $limit = null, ?int $offset = null): array
     {
         return $this->findBy([], ['timestamp' => $order], $limit, $offset);
     }
diff --git a/src/Security/ApiTokenAuthenticator.php b/src/Security/ApiTokenAuthenticator.php
@@ -131,7 +131,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
     /**
      * @see https://datatracker.ietf.org/doc/html/rfc6750#section-3
      */
-    private function getAuthenticateHeader(string $errorDescription = null): string
+    private function getAuthenticateHeader(?string $errorDescription = null): string
     {
         $data = [
             'realm' => $this->realm,
diff --git a/src/Security/AuthenticationEntryPoint.php b/src/Security/AuthenticationEntryPoint.php
@@ -47,7 +47,7 @@ public function __construct(
     ) {
     }
 
-    public function start(Request $request, AuthenticationException $authException = null): Response
+    public function start(Request $request, ?AuthenticationException $authException = null): Response
     {
         //Check if the request is an API request
         if ($this->isJSONRequest($request)) {
diff --git a/src/Security/SamlUserFactory.php b/src/Security/SamlUserFactory.php
@@ -116,10 +116,10 @@ public function mapSAMLAttributesToLocalGroup(array $attributes): ?Group
      * Maps a list of SAML roles to a local group ID.
      * The first available mapping will be used (so the order of the $map is important, first match wins).
      * @param  array  $roles The list of SAML roles
-     * @param  array  $map|null The mapping from SAML roles. If null, the global mapping will be used.
+     * @param  array|null  $map The mapping from SAML roles. If null, the global mapping will be used.
      * @return int|null The ID of the local group or null if no mapping was found.
      */
-    public function mapSAMLRolesToLocalGroupID(array $roles, array $map = null): ?int
+    public function mapSAMLRolesToLocalGroupID(array $roles, ?array $map = null): ?int
     {
         $map ??= $this->saml_role_mapping;
 
diff --git a/src/Serializer/AttachmentNormalizer.php b/src/Serializer/AttachmentNormalizer.php
@@ -42,7 +42,7 @@ public function __construct(
     {
     }
 
-    public function normalize(mixed $object, string $format = null, array $context = []): array|null
+    public function normalize(mixed $object, ?string $format = null, array $context = []): array|null
     {
         if (!$object instanceof Attachment) {
             throw new \InvalidArgumentException('This normalizer only supports Attachment objects!');
@@ -60,7 +60,7 @@ public function normalize(mixed $object, string $format = null, array $context =
         return $data;
     }
 
-    public function supportsNormalization(mixed $data, string $format = null, array $context = []): bool
+    public function supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool
     {
         // avoid recursion: only call once per object
         if (isset($context[self::ALREADY_CALLED])) {
diff --git a/src/Serializer/BigNumberNormalizer.php b/src/Serializer/BigNumberNormalizer.php
@@ -33,12 +33,12 @@
 class BigNumberNormalizer implements NormalizerInterface, DenormalizerInterface
 {
 
-    public function supportsNormalization($data, string $format = null, array $context = []): bool
+    public function supportsNormalization($data, ?string $format = null, array $context = []): bool
     {
         return $data instanceof BigNumber;
     }
 
-    public function normalize($object, string $format = null, array $context = []): string
+    public function normalize($object, ?string $format = null, array $context = []): string
     {
         if (!$object instanceof BigNumber) {
             throw new \InvalidArgumentException('This normalizer only supports BigNumber objects!');
@@ -58,7 +58,7 @@ public function getSupportedTypes(?string $format): array
         ];
     }
 
-    public function denormalize(mixed $data, string $type, string $format = null, array $context = []): BigNumber|null
+    public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): BigNumber|null
     {
         if (!is_a($type, BigNumber::class, true)) {
             throw new \InvalidArgumentException('This normalizer only supports BigNumber objects!');
@@ -67,7 +67,7 @@ public function denormalize(mixed $data, string $type, string $format = null, ar
         return $type::of($data);
     }
 
-    public function supportsDenormalization(mixed $data, string $type, string $format = null, array $context = []): bool
+    public function supportsDenormalization(mixed $data, string $type, ?string $format = null, array $context = []): bool
     {
         //data must be a string or a number (int, float, etc.) and the type must be BigNumber or BigDecimal
         return (is_string($data) || is_numeric($data)) && (is_subclass_of($type, BigNumber::class));
diff --git a/src/Serializer/PartNormalizer.php b/src/Serializer/PartNormalizer.php
@@ -63,13 +63,13 @@ public function __construct(
     {
     }
 
-    public function supportsNormalization($data, string $format = null, array $context = []): bool
+    public function supportsNormalization($data, ?string $format = null, array $context = []): bool
     {
         //We only remove the type field for CSV export
         return !isset($context[self::ALREADY_CALLED]) && $format === 'csv' && $data instanceof Part ;
     }
 
-    public function normalize($object, string $format = null, array $context = []): array
+    public function normalize($object, ?string $format = null, array $context = []): array
     {
         if (!$object instanceof Part) {
             throw new \InvalidArgumentException('This normalizer only supports Part objects!');
@@ -117,7 +117,7 @@ private function normalizeKeys(array &$data): array
         return $data;
     }
 
-    public function denormalize($data, string $type, string $format = null, array $context = []): ?Part
+    public function denormalize($data, string $type, ?string $format = null, array $context = []): ?Part
     {
         $this->normalizeKeys($data);
 
diff --git a/src/Serializer/StructuralElementDenormalizer.php b/src/Serializer/StructuralElementDenormalizer.php
@@ -49,7 +49,7 @@ public function __construct(
     {
     }
 
-    public function supportsDenormalization($data, string $type, string $format = null, array $context = []): bool
+    public function supportsDenormalization($data, string $type, ?string $format = null, array $context = []): bool
     {
         //Only denormalize if we are doing a file import operation
         if (!($context['partdb_import'] ?? false)) {
@@ -78,7 +78,7 @@ public function supportsDenormalization($data, string $type, string $format = nu
      * @return AbstractStructuralDBElement|null
      * @phpstan-return T|null
      */
-    public function denormalize($data, string $type, string $format = null, array $context = []): ?AbstractStructuralDBElement
+    public function denormalize($data, string $type, ?string $format = null, array $context = []): ?AbstractStructuralDBElement
     {
         //Do not use API Platform's denormalizer
         $context[SkippableItemNormalizer::DISABLE_ITEM_NORMALIZER] = true;
diff --git a/src/Serializer/StructuralElementFromNameDenormalizer.php b/src/Serializer/StructuralElementFromNameDenormalizer.php
@@ -36,7 +36,7 @@ public function __construct(private readonly EntityManagerInterface $em)
     {
     }
 
-    public function supportsDenormalization($data, string $type, string $format = null, array $context = []): bool
+    public function supportsDenormalization($data, string $type, ?string $format = null, array $context = []): bool
     {
         //Only denormalize if we are doing a file import operation
         if (!($context['partdb_import'] ?? false)) {
@@ -51,7 +51,7 @@ public function supportsDenormalization($data, string $type, string $format = nu
      * @phpstan-param class-string<T> $type
      * @phpstan-return T|null
      */
-    public function denormalize($data, string $type, string $format = null, array $context = []): AbstractStructuralDBElement|null
+    public function denormalize($data, string $type, ?string $format = null, array $context = []): AbstractStructuralDBElement|null
     {
         //Retrieve the repository for the given type
         /** @var StructuralDBElementRepository<T> $repo */
diff --git a/src/Serializer/StructuralElementNormalizer.php b/src/Serializer/StructuralElementNormalizer.php
@@ -38,7 +38,7 @@ public function __construct(
     {
     }
 
-    public function supportsNormalization($data, string $format = null, array $context = []): bool
+    public function supportsNormalization($data, ?string $format = null, array $context = []): bool
     {
         //Only normalize if we are doing a file export operation
         if (!($context['partdb_export'] ?? false)) {
@@ -48,7 +48,7 @@ public function supportsNormalization($data, string $format = null, array $conte
         return $data instanceof AbstractStructuralDBElement;
     }
 
-    public function normalize($object, string $format = null, array $context = []): mixed
+    public function normalize($object, ?string $format = null, array $context = []): mixed
     {
         if (!$object instanceof AbstractStructuralDBElement) {
             throw new \InvalidArgumentException('This normalizer only supports AbstractStructural objects!');
diff --git a/src/Services/ImportExportSystem/EntityImporter.php b/src/Services/ImportExportSystem/EntityImporter.php
@@ -357,7 +357,7 @@ public function determineFormat(string $extension): ?string
      * @param iterable                         $entities the list of entities that should be fixed
      * @param  AbstractStructuralDBElement|null  $parent   the parent, to which the entity should be set
      */
-    protected function correctParentEntites(iterable $entities, AbstractStructuralDBElement $parent = null): void
+    protected function correctParentEntites(iterable $entities, ?AbstractStructuralDBElement $parent = null): void
     {
         foreach ($entities as $entity) {
             /** @var AbstractStructuralDBElement $entity */
diff --git a/src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php b/src/Services/InfoProviderSystem/Providers/OEMSecretsProvider.php
@@ -1221,7 +1221,7 @@ private function customParseValueIncludingUnit(string $name, string $value): arr
      *               - 'value_min' => string|null The minimum value in a range, if applicable.
      *               - 'value_max' => string|null The maximum value in a range, if applicable.
      */
-    private function customSplitIntoValueAndUnit(string $value1, string $value2 = null): array
+    private function customSplitIntoValueAndUnit(string $value1, ?string $value2 = null): array
     {
         // Separate numbers and units (basic parsing handling)
         $unit = null;
diff --git a/src/Validator/Constraints/UniqueObjectCollection.php b/src/Validator/Constraints/UniqueObjectCollection.php
@@ -43,12 +43,12 @@ class UniqueObjectCollection extends Constraint
      * @param array|string $fields the combination of fields that must contain unique values or a set of options
      */
     public function __construct(
-        array $options = null,
-        string $message = null,
-        callable $normalizer = null,
-        array $groups = null,
+        ?array $options = null,
+        ?string $message = null,
+        ?callable $normalizer = null,
+        ?array $groups = null,
         mixed $payload = null,
-        array|string $fields = null,
+        array|string|null $fields = null,
         public bool $allowNull = true,
     ) {
         parent::__construct($options, $groups, $payload);
diff --git a/src/Validator/Constraints/ValidGoogleAuthCode.php b/src/Validator/Constraints/ValidGoogleAuthCode.php
@@ -31,8 +31,8 @@ class ValidGoogleAuthCode extends Constraint
      * @param  TwoFactorInterface|null  $user The user to use for the validation process, if null, the current user is used
      */
     public function __construct(
-        array $options = null,
-        array $groups = null,
+        ?array $options = null,
+        ?array $groups = null,
         mixed $payload = null,
         public ?TwoFactorInterface $user = null)
     {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@`
`35`	`35`	`#[AsCommand('partdb:users:enable\|partdb:user:enable', 'Enables/Disable the login of one or more users')]`
`36`	`36`	`class UserEnableCommand extends Command`
`37`	`37`	`{`
`38`		`- public function __construct(protected EntityManagerInterface $entityManager, string $name = null)`
	`38`	`+ public function __construct(protected EntityManagerInterface $entityManager, ?string $name = null)`
`39`	`39`	`{`
`40`	`40`	`parent::__construct($name);`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ class TwoStepORMAdapter extends ORMAdapter`
`54`	`54`
`55`	`55`	`private \Closure\|null $query_modifier = null;`
`56`	`56`
`57`		`- public function __construct(ManagerRegistry $registry = null)`
	`57`	`+ public function __construct(?ManagerRegistry $registry = null)`
`58`	`58`	`{`
`59`	`59`	`parent::__construct($registry);`
`60`	`60`	`$this->detailQueryCallable = static function (QueryBuilder $qb, array $ids): never {`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function __construct(`
`45`	`45`	`* @var string The property where this BooleanConstraint should apply to`
`46`	`46`	`*/`
`47`	`47`	`protected string $property,`
`48`		`- string $identifier = null)`
	`48`	`+ ?string $identifier = null)`
`49`	`49`	`{`
`50`	`50`	`$this->identifier = $identifier ?? $this->generateParameterIdentifier($property);`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class BooleanConstraint extends AbstractConstraint`
`28`	`28`	`{`
`29`	`29`	`public function __construct(`
`30`	`30`	`string $property,`
`31`		`- string $identifier = null,`
	`31`	`+ ?string $identifier = null,`
`32`	`32`	`/** @var bool\|null The value of our constraint */`
`33`	`33`	`protected ?bool $value = null`
`34`	`34`	`)`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class EntityConstraint extends AbstractConstraint`
`46`	`46`	`public function __construct(protected ?NodesListBuilder $nodesListBuilder,`
`47`	`47`	`protected string $class,`
`48`	`48`	`string $property,`
`49`		`- string $identifier = null,`
	`49`	`+ ?string $identifier = null,`
`50`	`50`	`protected ?AbstractDBElement $value = null,`
`51`	`51`	`protected ?string $operator = null)`
`52`	`52`	`{`