Return a 404 message, instead of creating an 500 Runtime exception, when a file associated with an attachment is not existing.

This fails more gracefully, and do not pollute log files.

Author: jbtronics

src/Controller/AttachmentFileController.php

@@ -52,11 +52,11 @@ public function download(Attachment $attachment, AttachmentManager $helper): Bin
         }
 
         if ($attachment->isExternal()) {
-            throw new RuntimeException('You can not download external attachments!');
+            throw $this->createNotFoundException('The file for this attachment is external and can not stored locally!');
         }
 
         if (!$helper->isFileExisting($attachment)) {
-            throw new RuntimeException('The file associated with the attachment is not existing!');
+            throw $this->createNotFoundException('The file associated with the attachment is not existing!');
         }
 
         $file_path = $helper->toAbsoluteFilePath($attachment);
@@ -81,11 +81,11 @@ public function view(Attachment $attachment, AttachmentManager $helper): BinaryF
         }
 
         if ($attachment->isExternal()) {
-            throw new RuntimeException('You can not download external attachments!');
+            throw $this->createNotFoundException('The file for this attachment is external and can not stored locally!');
         }
 
         if (!$helper->isFileExisting($attachment)) {
-            throw new RuntimeException('The file associated with the attachment is not existing!');
+            throw $this->createNotFoundException('The file associated with the attachment is not existing!');
         }
 
         $file_path = $helper->toAbsoluteFilePath($attachment);