Skip to content

Commit c735bfd

Browse files
committed
Made the titles of the settings categories translatable
This fixes issue #1037
1 parent 41dbc27 commit c735bfd

File tree

6 files changed

+87
-64
lines changed

6 files changed

+87
-64
lines changed

src/Settings/AppSettings.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
use App\Settings\BehaviorSettings\BehaviorSettings;
2727
use App\Settings\InfoProviderSystem\InfoProviderSettings;
2828
use App\Settings\MiscSettings\MiscSettings;
29-
use App\Settings\SystemSettings\AttachmentsSettings;
29+
use App\Settings\SystemSettings\SystemSettings;
3030
use Jbtronics\SettingsBundle\Settings\EmbeddedSettings;
3131
use Jbtronics\SettingsBundle\Settings\Settings;
3232
use Jbtronics\SettingsBundle\Settings\SettingsTrait;
@@ -49,4 +49,4 @@ class AppSettings
4949

5050
#[EmbeddedSettings()]
5151
public ?MiscSettings $miscSettings = null;
52-
}
52+
}

src/Settings/BehaviorSettings/BehaviorSettings.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@
2626
use Jbtronics\SettingsBundle\Settings\EmbeddedSettings;
2727
use Jbtronics\SettingsBundle\Settings\Settings;
2828
use Jbtronics\SettingsBundle\Settings\SettingsTrait;
29+
use Symfony\Component\Translation\TranslatableMessage as TM;
2930

30-
#[Settings]
31+
#[Settings(label: new TM("settings.behavior"))]
3132
class BehaviorSettings
3233
{
3334
use SettingsTrait;
@@ -40,4 +41,4 @@ class BehaviorSettings
4041

4142
#[EmbeddedSettings]
4243
public ?PartInfoSettings $partInfo = null;
43-
}
44+
}

src/Settings/InfoProviderSystem/InfoProviderSettings.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@
2727
use Jbtronics\SettingsBundle\Settings\Settings;
2828
use Jbtronics\SettingsBundle\Settings\SettingsParameter;
2929
use Jbtronics\SettingsBundle\Settings\SettingsTrait;
30+
use Symfony\Component\Translation\TranslatableMessage as TM;
3031

31-
#[Settings()]
32+
#[Settings(label: new TM("settings.ips"))]
3233
class InfoProviderSettings
3334
{
3435
use SettingsTrait;

src/Settings/MiscSettings/MiscSettings.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@
2525

2626
use Jbtronics\SettingsBundle\Settings\EmbeddedSettings;
2727
use Jbtronics\SettingsBundle\Settings\Settings;
28+
use Symfony\Component\Translation\TranslatableMessage as TM;
2829

29-
#[Settings]
30+
#[Settings(label: new TM("settings.misc"))]
3031
class MiscSettings
3132
{
3233
#[EmbeddedSettings]
3334
public ?KiCadEDASettings $kicadEDA = null;
3435

3536
#[EmbeddedSettings]
3637
public ?ExchangeRateSettings $exchangeRate = null;
37-
}
38+
}

src/Settings/SystemSettings.php renamed to src/Settings/SystemSettings/SystemSettings.php

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,13 @@
2121
declare(strict_types=1);
2222

2323

24-
namespace App\Settings;
24+
namespace App\Settings\SystemSettings;
2525

26-
use App\Settings\SystemSettings\AttachmentsSettings;
27-
use App\Settings\SystemSettings\CustomizationSettings;
28-
use App\Settings\SystemSettings\HistorySettings;
29-
use App\Settings\SystemSettings\LocalizationSettings;
30-
use App\Settings\SystemSettings\PrivacySettings;
3126
use Jbtronics\SettingsBundle\Settings\EmbeddedSettings;
3227
use Jbtronics\SettingsBundle\Settings\Settings;
28+
use Symfony\Component\Translation\TranslatableMessage as TM;
3329

34-
#[Settings]
30+
#[Settings(label: new TM("settings.system"))]
3531
class SystemSettings
3632
{
3733
#[EmbeddedSettings()]
@@ -48,4 +44,4 @@ class SystemSettings
4844

4945
#[EmbeddedSettings()]
5046
public ?HistorySettings $history = null;
51-
}
47+
}

0 commit comments

Comments
 (0)