Add more tests and fix failing ones

Author: barisgit

src/Services/ImportExportSystem/EntityExporter.php

@@ -102,22 +102,24 @@ public function exportEntities(AbstractNamedDBElement|array $entities, array $op
             $groups[] = 'include_children';
         }
 
-        return $this->serializer->serialize($entities, $options['format'],
+        return $this->serializer->serialize(
+            $entities,
+            $options['format'],
             [
                 'groups' => $groups,
                 'as_collection' => true,
                 'csv_delimiter' => $options['csv_delimiter'],
                 'xml_root_node_name' => 'PartDBExport',
                 'partdb_export' => true,
-                //Skip the item normalizer, so that we dont get IRIs in the output
+                    //Skip the item normalizer, so that we dont get IRIs in the output
                 SkippableItemNormalizer::DISABLE_ITEM_NORMALIZER => true,
-                //Handle circular references
+                    //Handle circular references
                 AbstractNormalizer::CIRCULAR_REFERENCE_HANDLER => $this->handleCircularReference(...),
             ]
         );
     }
 
-    private function handleCircularReference(object $object, string $format, array $context): string
+    private function handleCircularReference(object $object): string
     {
         if ($object instanceof AbstractStructuralDBElement) {
             return $object->getFullPath("->");
@@ -127,7 +129,7 @@ private function handleCircularReference(object $object, string $format, array $
             return $object->__toString();
         }
 
-        throw new CircularReferenceException('Circular reference detected for object of type '.get_class($object));
+        throw new CircularReferenceException('Circular reference detected for object of type ' . get_class($object));
     }
 
     /**
@@ -148,7 +150,9 @@ protected function exportToExcel(array $entities, array $options): string
             $groups[] = 'include_children';
         }
 
-        $csvData = $this->serializer->serialize($entities, 'csv',
+        $csvData = $this->serializer->serialize(
+            $entities,
+            'csv',
             [
                 'groups' => $groups,
                 'as_collection' => true,
@@ -162,18 +166,18 @@ protected function exportToExcel(array $entities, array $options): string
         //Convert CSV to Excel
         $spreadsheet = new Spreadsheet();
         $worksheet = $spreadsheet->getActiveSheet();
-        
+
         $rows = explode("\n", $csvData);
         $rowIndex = 1;
-        
+
         foreach ($rows as $row) {
             if (trim($row) === '') {
                 continue;
             }
-            
-            $columns = str_getcsv($row, $options['csv_delimiter']);
+
+            $columns = str_getcsv($row, $options['csv_delimiter'], '"', '\\');
             $colIndex = 1;
-            
+
             foreach ($columns as $column) {
                 $cellCoordinate = \PhpOffice\PhpSpreadsheet\Cell\Coordinate::stringFromColumnIndex($colIndex) . $rowIndex;
                 $worksheet->setCellValue($cellCoordinate, $column);
@@ -183,17 +187,13 @@ protected function exportToExcel(array $entities, array $options): string
         }
 
         //Save to memory stream
-        if ($options['format'] === 'xlsx') {
-            $writer = new Xlsx($spreadsheet);
-        } else {
-            $writer = new Xls($spreadsheet);
-        }
-        
+        $writer = $options['format'] === 'xlsx' ? new Xlsx($spreadsheet) : new Xls($spreadsheet);
+
         ob_start();
         $writer->save('php://output');
         $content = ob_get_contents();
         ob_end_clean();
-        
+
         return $content;
     }
 
@@ -231,25 +231,15 @@ public function exportEntityFromRequest(AbstractNamedDBElement|array $entities,
 
         //Determine the content type for the response
 
-        //Plain text should work for all types
-        $content_type = 'text/plain';
-
         //Try to use better content types based on the format
         $format = $options['format'];
-        switch ($format) {
-            case 'xml':
-                $content_type = 'application/xml';
-                break;
-            case 'json':
-                $content_type = 'application/json';
-                break;
-            case 'xlsx':
-                $content_type = 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet';
-                break;
-            case 'xls':
-                $content_type = 'application/vnd.ms-excel';
-                break;
-        }
+        $content_type = match ($format) {
+            'xml' => 'application/xml',
+            'json' => 'application/json',
+            'xlsx' => 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
+            'xls' => 'application/vnd.ms-excel',
+            default => 'text/plain',
+        };
         $response->headers->set('Content-Type', $content_type);
 
         //If view option is not specified, then download the file.
@@ -267,7 +257,7 @@ public function exportEntityFromRequest(AbstractNamedDBElement|array $entities,
 
             $level = $options['level'];
 
-            $filename = 'export_'.$entity_name.'_'.$level.'.'.$format;
+            $filename = "export_{$entity_name}_{$level}.{$format}";
 
             //Sanitize the filename
             $filename = FilenameSanatizer::sanitizeFilename($filename);

tests/Services/Parts/PartsTableActionHandlerTest.php

@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of Part-DB (https://github.com/Part-DB/Part-DB-symfony).
+ *
+ *  Copyright (C) 2019 - 2023 Jan Böhmer (https://github.com/jbtronics)
+ *
+ *  This program is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU Affero General Public License as published
+ *  by the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU Affero General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Affero General Public License
+ *  along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+namespace App\Tests\Services\Parts;
+
+use App\Entity\Parts\Part;
+use App\Services\Parts\PartsTableActionHandler;
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\HttpFoundation\RedirectResponse;
+
+class PartsTableActionHandlerTest extends WebTestCase
+{
+    private PartsTableActionHandler $service;
+
+    protected function setUp(): void
+    {
+        self::bootKernel();
+        $this->service = self::getContainer()->get(PartsTableActionHandler::class);
+    }
+
+    public function testExportActionsRedirectToExportController(): void
+    {
+        // Mock a Part entity with required properties
+        $part = $this->createMock(Part::class);
+        $part->method('getId')->willReturn(1);
+        $part->method('getName')->willReturn('Test Part');
+        
+        $selected_parts = [$part];
+
+        // Test each export format, focusing on our new xlsx format
+        $formats = ['json', 'csv', 'xml', 'yaml', 'xlsx'];
+        
+        foreach ($formats as $format) {
+            $action = "export_{$format}";
+            $result = $this->service->handleAction($action, $selected_parts, 1, '/test');
+            
+            $this->assertInstanceOf(RedirectResponse::class, $result);
+            $this->assertStringContainsString('parts/export', $result->getTargetUrl());
+            $this->assertStringContainsString("format={$format}", $result->getTargetUrl());
+        }
+    }
+
+    public function testIdStringToArray(): void
+    {
+        // This test would require actual Part entities in the database
+        // For now, we just test the method exists and handles empty strings
+        $result = $this->service->idStringToArray('');
+        $this->assertIsArray($result);
+        $this->assertEmpty($result);
+    }
+}