Addressed review comments and updated the code as per the feedback

Author: ParthPore10

highs/highs_bindings.cpp

@@ -28,6 +28,16 @@ std::function<dense_array_t<T>(const Base&)> make_readonly_ptr(
   };
 }
 
+template<typename Base, typename T>
+std::function<void(Base&, dense_array_t<T>)> make_vector_setter(
+    std::vector<T> Base::* member){
+  return [member](Base& self,dense_array_t<T>values){
+    auto buf = values.request();
+    auto ptr = static_cast<T*>(buf.ptr);
+    (self.*member).assign(ptr, ptr + buf.size);
+  };
+}
+
 HighsStatus highs_passModel(Highs* h, HighsModel& model) {
   return h->passModel(model);
 }
@@ -1059,7 +1069,8 @@ PYBIND11_MODULE(_core, m, py::mod_gil_not_used()) {
       .def(py::init<>())
       .def_readwrite("num_col_", &HighsLp::num_col_)
       .def_readwrite("num_row_", &HighsLp::num_row_)
-      .def_readwrite("col_cost_", &HighsLp::col_cost_)
+      .def_property("col_cost_", make_readonly_ptr(&HighsLp::col_cost_),
+                    make_vector_setter(&HighsLp::col_cost_))
       .def_readwrite("col_lower_", &HighsLp::col_lower_)
       .def_readwrite("col_upper_", &HighsLp::col_upper_)
       .def_readwrite("row_lower_", &HighsLp::row_lower_)

highs/highspy/_core/__init__.pyi

@@ -262,7 +262,7 @@ class HighsLogType:
 
 class HighsLp:
     a_matrix_: HighsSparseMatrix
-    col_cost_: list[float]
+    col_cost_: numpy.ndarray[typing.Any, numpy.dtype[numpy.float64]]
     col_lower_: list[float]
     col_names_: list[str]
     col_upper_: list[float]
@@ -525,11 +525,11 @@ class HighsScale:
     pass
 
 class HighsSolution:
-    col_dual: list[float]
-    col_value: list[float]
+    col_dual: numpy.ndarray[typing.Any, numpy.dtype[numpy.float64]]
+    col_value: numpy.ndarray[typing.Any, numpy.dtype[numpy.float64]]
     dual_valid: bool
-    row_dual: list[float]
-    row_value: list[float]
+    row_dual: numpy.ndarray[typing.Any, numpy.dtype[numpy.float64]]
+    row_value: numpy.ndarray[typing.Any, numpy.dtype[numpy.float64]]
     value_valid: bool
 
     def __init__(self) -> None: ...

highs/highspy/highs.py

@@ -36,11 +36,6 @@ class Highs(_Highs):
     __solver_started: Lock = Lock()
     __solver_status: Optional[HighsStatus] = None
 
-    @staticmethod
-    def float_array(vals):
-        if isinstance(vals,np.ndarray): return vals
-        return np.asarray(vals,dtype=np.float64)
-
     def __init__(self):
         super().__init__()
         self.callbacks = [HighsCallback(cb.HighsCallbackType(_), self) for _ in range(int(cb.HighsCallbackType.kCallbackMax) + 1)]
@@ -184,15 +179,6 @@ def optimize(self):
         """
         return self.solve()
 
-    def getSolution(self):
-        #retriving the current solution to numpy vector fields
-        solution = super().getSolution()
-        solution.col_value = Highs.float_array(solution.col_value)
-        solution.col_dual = Highs.float_array(solution.col_dual)
-        solution.row_value = Highs.float_array(solution.row_value)
-        solution.row_dual = Highs.float_array(solution.row_dual)
-        return solution
-
     # reset the objective
     def setObjective(self, obj: Optional[Union[highs_var, highs_linear_expression]] = None, sense: Optional[ObjSense] = None):
         """
@@ -308,7 +294,7 @@ def val(
         Returns:
             The value of the variable in the solution.
         """
-        return Highs.internal_get_value(self.getSolution().col_value, var)
+        return Highs.internal_get_value(super().getSolution().col_value, var)
 
     @overload
     def vals(self, idxs: Union[Integral, highs_var, highs_cons]) -> float: ...
@@ -335,7 +321,7 @@ def vals(
         Returns:
             If idxs is a Mapping, returns a dict where keys are the same keys from the input idxs and values are the solution values of the corresponding variables. If idxs is an iterable, returns a list of solution values for the variables.
         """
-        return Highs.internal_get_value(self.getSolution().col_value, idxs)
+        return Highs.internal_get_value(super().getSolution().col_value, idxs)
 
     def variableName(self, var: Union[Integral, highs_var]):
         """
@@ -428,7 +414,7 @@ def allVariableValues(self):
         Returns:
             A list of values for all variables in the solution.
         """
-        return self.getSolution().col_value
+        return super().getSolution().col_value
 
     def variableDual(
         self,
@@ -443,7 +429,7 @@ def variableDual(
         Returns:
             The dual value of the specified variable in the solution.
         """
-        return Highs.internal_get_value(self.getSolution().col_dual, var)
+        return Highs.internal_get_value(super().getSolution().col_dual, var)
 
     def variableDuals(
         self,
@@ -458,7 +444,7 @@ def variableDuals(
         Returns:
             If idxs is a Mapping, returns a dict where keys are the same keys from the input idxs and values are the dual values of the corresponding variables. If idxs is an iterable, returns a list of dual values for the variables.
         """
-        return Highs.internal_get_value(self.getSolution().col_dual, idxs)
+        return Highs.internal_get_value(super().getSolution().col_dual, idxs)
 
     def allVariableDuals(self):
         """
@@ -467,7 +453,7 @@ def allVariableDuals(self):
         Returns:
             A list of dual values for all variables in the solution.
         """
-        return self.getSolution().col_dual
+        return super().getSolution().col_dual
 
     def constrValue(
         self,
@@ -482,7 +468,7 @@ def constrValue(
         Returns:
             The value of the specified constraint in the solution.
         """
-        return Highs.internal_get_value(self.getSolution().row_value, con)
+        return Highs.internal_get_value(super().getSolution().row_value, con)
 
     def constrValues(
         self,
@@ -497,7 +483,7 @@ def constrValues(
         Returns:
             If cons is a Mapping, returns a dict where keys are the same keys from the input cons and values are the solution values of the corresponding constraints. If cons is an iterable, returns a list of solution values for the constraints.
         """
-        return Highs.internal_get_value(self.getSolution().row_value, cons)
+        return Highs.internal_get_value(super().getSolution().row_value, cons)
 
     def allConstrValues(self):
         """
@@ -521,7 +507,7 @@ def constrDual(
         Returns:
             The dual value of the specified constraint in the solution.
         """
-        return Highs.internal_get_value(self.getSolution().row_dual, con)
+        return Highs.internal_get_value(super().getSolution().row_dual, con)
 
     def constrDuals(
         self,
@@ -536,7 +522,7 @@ def constrDuals(
         Returns:
             If cons is a Mapping, returns a dict where keys are the same keys from the input cons and values are the dual values of the corresponding constraints. If cons is an iterable, returns a list of dual values for the constraints.
         """
-        return Highs.internal_get_value(self.getSolution().row_dual, cons)
+        return Highs.internal_get_value(super().getSolution().row_dual, cons)
 
     def allConstrDuals(self):
         """
@@ -545,7 +531,7 @@ def allConstrDuals(self):
         Returns:
             A list of dual values for all constraints in the solution.
         """
-        return self.getSolution().row_dual
+        return super().getSolution().row_dual
 
     def addVariable(
         self,