Fix failing command line tests (#2798) (#2802)

* No need for double

* Fix the bug by forcing the right parameter to be used

---------

Co-authored-by: Daniel Marbach <[email protected]>

Author: danielmarbach

src/CommandLine/DefaultConfigurationValues.cs

@@ -11,11 +11,5 @@ public static class DefaultConfigurationValues
 
         public static readonly string QueueNamePrefix = string.Empty;
         public static readonly string TopicNamePrefix = string.Empty;
-
-        /* TODO: look into these, why are they different from the above?
-         public static readonly int AwsMaximumQueueDelayTime = (int)TimeSpan.FromMinutes(15).TotalSeconds;
-         public static readonly TimeSpan DelayedDeliveryQueueMessageRetentionPeriod = TimeSpan.FromDays(4);
-         public static readonly int DelayedDeliveryQueueDelayTime = Convert.ToInt32(Math.Ceiling(MaximumQueueDelayTime.TotalSeconds));
-         */
     }
 }

src/CommandLine/Program.cs

@@ -68,12 +68,12 @@ static int Main(string[] args)
                     createCommand.AddOption(prefixOption);
 
                     var retentionPeriodInSecondsCommand = createCommand.Option("-t|--retention",
-                        $"Retention Period in seconds (defaults to {DefaultConfigurationValues.RetentionPeriod.TotalSeconds} ) ", CommandOptionType.SingleValue);
+                        $"Retention Period in seconds (defaults to {(int)DefaultConfigurationValues.RetentionPeriod.TotalSeconds} ) ", CommandOptionType.SingleValue);
 
                     createCommand.OnExecuteAsync(async ct =>
                     {
                         var endpointName = nameArgument.Value;
-                        var retentionPeriodInSeconds = retentionPeriodInSecondsCommand.HasValue() ? double.Parse(retentionPeriodInSecondsCommand.Value()) : DefaultConfigurationValues.RetentionPeriod.TotalSeconds;
+                        var retentionPeriodInSeconds = retentionPeriodInSecondsCommand.HasValue() ? int.Parse(retentionPeriodInSecondsCommand.Value()) : (int)DefaultConfigurationValues.RetentionPeriod.TotalSeconds;
                         var prefix = prefixOption.HasValue() ? prefixOption.Value() : DefaultConfigurationValues.QueueNamePrefix;
 
                         await CommandRunner.Run(accessKeyOption, secretOption, regionOption, (sqs, sns, s3) => Endpoint.Create(sqs, prefix, endpointName, retentionPeriodInSeconds));
@@ -140,8 +140,8 @@ static int Main(string[] args)
 
                         delayDeliverySupportCommand.OnExecuteAsync(async ct =>
                         {
-                            var delayInSeconds = DefaultConfigurationValues.MaximumQueueDelayTime.TotalSeconds;
-                            var retentionPeriodInSeconds = retentionPeriodInSecondsCommand.HasValue() ? double.Parse(retentionPeriodInSecondsCommand.Value()) : DefaultConfigurationValues.RetentionPeriod.TotalSeconds;
+                            var delayInSeconds = (int)DefaultConfigurationValues.MaximumQueueDelayTime.TotalSeconds;
+                            var retentionPeriodInSeconds = retentionPeriodInSecondsCommand.HasValue() ? int.Parse(retentionPeriodInSecondsCommand.Value()) : (int)DefaultConfigurationValues.RetentionPeriod.TotalSeconds;
                             var suffix = DefaultConfigurationValues.DelayedDeliveryQueueSuffix;
 
                             var endpointName = nameArgument.Value;