Management API configuration does not allow HTTPS URLs (#1587)

* Bump RabbitMQ.Client from 7.1.1 to 7.1.2 in /src

Bumps [RabbitMQ.Client](https://github.com/rabbitmq/rabbitmq-dotnet-client) from 7.1.1 to 7.1.2.
- [Release notes](https://github.com/rabbitmq/rabbitmq-dotnet-client/releases)
- [Changelog](https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/CHANGELOG.md)
- [Commits](rabbitmq/rabbitmq-dotnet-client@v7.1.1...v7.1.2)

---
updated-dependencies:
- dependency-name: RabbitMQ.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix condition to allow https management API connections

* Add failing test

* Fix scheme checking condition

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: bording

src/NServiceBus.Transport.RabbitMQ.CommandLine/NServiceBus.Transport.RabbitMQ.CommandLine.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
@@ -18,7 +18,7 @@
 
   <ItemGroup>
     <PackageReference Include="NServiceBus" Version="9.2.6" />
-    <PackageReference Include="RabbitMQ.Client" Version="7.1.1" />
+    <PackageReference Include="RabbitMQ.Client" Version="7.1.2" />
     <PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
   </ItemGroup>
 

src/NServiceBus.Transport.RabbitMQ.Tests/ManagementClientTests.cs

@@ -18,6 +18,22 @@ class ManagementClientTests
         static readonly ConnectionConfiguration connectionConfiguration = ConnectionConfiguration.Create(connectionString);
         static readonly ConnectionFactory connectionFactory = new(typeof(ManagementClientTests).FullName, connectionConfiguration, null, false, false, TimeSpan.FromSeconds(60), TimeSpan.FromSeconds(10), []);
 
+        [Test]
+        public void Should_Pass_With_http_Scheme()
+        {
+            var managementApiConfiguration = new ManagementApiConfiguration("http://localhost:15672");
+
+            Assert.DoesNotThrow(() => new ManagementClient(connectionConfiguration, managementApiConfiguration));
+        }
+
+        [Test]
+        public void Should_Pass_With_https_Scheme()
+        {
+            var managementApiConfiguration = new ManagementApiConfiguration("https://localhost:15671");
+
+            Assert.DoesNotThrow(() => new ManagementClient(connectionConfiguration, managementApiConfiguration));
+        }
+
         [Test]
         public void Should_Throw_With_Invalid_Scheme()
         {

src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/ManagementClient.cs

@@ -34,7 +34,7 @@ public ManagementClient(ConnectionConfiguration connectionConfiguration, Managem
                 Password = managementApiConfiguration.Password ?? connectionConfiguration.Password
             };
 
-            if (uriBuilder.Scheme is not "http" or "https")
+            if (uriBuilder.Scheme is not ("http" or "https"))
             {
                 throw new NotSupportedException($"URL scheme '{uriBuilder.Scheme}' is not supported for the RabbitMQ management API URL. Valid schemes are 'http' and 'https'.");
             }

src/NServiceBus.Transport.RabbitMQ/NServiceBus.Transport.RabbitMQ.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
@@ -10,7 +10,7 @@
   <ItemGroup>
     <PackageReference Include="BitFaster.Caching" Version="2.5.3" />
     <PackageReference Include="NServiceBus" Version="9.2.6" />
-    <PackageReference Include="RabbitMQ.Client" Version="7.1.1" />
+    <PackageReference Include="RabbitMQ.Client" Version="7.1.2" />
   </ItemGroup>
 
   <ItemGroup>