Skip to content

Commit e8a251e

Browse files
committed
Merge pull request #131 from Particular/release-3.1.0
Release 3.1.0
2 parents 7a67b6d + bb9c8bd commit e8a251e

15 files changed

+61
-58
lines changed

packaging/nuget/NServiceBus.RabbitMQ.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<tags>nservicebus servicebus msmq cqrs publish subscribe</tags>
1717
<dependencies>
1818
<dependency id="NServiceBus" version="[5.0.0, 6.0.0)" />
19-
<dependency id="RabbitMQ.Client" version="[3.5.0, 3.6.0)" />
19+
<dependency id="RabbitMQ.Client" version="[3.6.0, 3.7.0)" />
2020
</dependencies>
2121
</metadata>
2222
<files>

src/NServiceBus.RabbitMQ.AcceptanceTests/NServiceBus.RabbitMQ.AcceptanceTests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@
4444
<SpecificVersion>False</SpecificVersion>
4545
<HintPath>..\packages\NUnit.2.6.4\lib\nunit.framework.dll</HintPath>
4646
</Reference>
47-
<Reference Include="RabbitMQ.Client, Version=3.5.0.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce, processorArchitecture=MSIL">
48-
<SpecificVersion>False</SpecificVersion>
49-
<HintPath>..\packages\RabbitMQ.Client.3.5.0\lib\net40\RabbitMQ.Client.dll</HintPath>
47+
<Reference Include="RabbitMQ.Client, Version=3.6.1.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce, processorArchitecture=MSIL">
48+
<HintPath>..\packages\RabbitMQ.Client.3.6.1\lib\net45\RabbitMQ.Client.dll</HintPath>
49+
<Private>True</Private>
5050
</Reference>
5151
<Reference Include="System" />
5252
<Reference Include="System.configuration" />

src/NServiceBus.RabbitMQ.AcceptanceTests/When_using_a_custom_message_id_strategy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public void Should_be_able_to_receive_messages_with_no_id()
3636
//for now until we can patch the serializer to infer the type based on the root node
3737
properties.Headers = new Dictionary<string, object> { { Headers.EnclosedMessageTypes, typeof(MyRequest).FullName } };
3838

39-
channel.BasicPublish(string.Empty, unicastBus.Configure.LocalAddress.Queue, true, false, properties, stream.ToArray());
39+
channel.BasicPublish(string.Empty, unicastBus.Configure.LocalAddress.Queue, true, properties, stream.ToArray());
4040
}
4141

4242
}

src/NServiceBus.RabbitMQ.AcceptanceTests/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<package id="NServiceBus.AcceptanceTesting" version="5.2.0" targetFramework="net45" />
55
<package id="NServiceBus.AcceptanceTests.Sources" version="5.2.0" targetFramework="net45" />
66
<package id="NUnit" version="2.6.4" targetFramework="net45" />
7-
<package id="RabbitMQ.Client" version="3.5.0" targetFramework="net45" />
7+
<package id="RabbitMQ.Client" version="3.6.1" targetFramework="net45" />
88
<package id="Rx-Core" version="2.2.5" targetFramework="net45" />
99
<package id="Rx-Interfaces" version="2.2.5" targetFramework="net45" />
1010
<package id="Rx-Linq" version="2.2.5" targetFramework="net45" />

src/NServiceBus.RabbitMQ.Tests/NServiceBus.RabbitMQ.Tests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@
6767
<SpecificVersion>False</SpecificVersion>
6868
<HintPath>..\packages\NUnit.2.6.4\lib\nunit.framework.dll</HintPath>
6969
</Reference>
70-
<Reference Include="RabbitMQ.Client, Version=3.5.0.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce, processorArchitecture=MSIL">
71-
<SpecificVersion>False</SpecificVersion>
72-
<HintPath>..\packages\RabbitMQ.Client.3.5.0\lib\net40\RabbitMQ.Client.dll</HintPath>
70+
<Reference Include="RabbitMQ.Client, Version=3.6.1.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce, processorArchitecture=MSIL">
71+
<HintPath>..\packages\RabbitMQ.Client.3.6.1\lib\net45\RabbitMQ.Client.dll</HintPath>
72+
<Private>True</Private>
7373
</Reference>
7474
<Reference Include="System" />
7575
<Reference Include="System.Core" />

src/NServiceBus.RabbitMQ.Tests/When_consuming_messages.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public void Should_block_until_a_message_is_available()
2222

2323
var message = new TransportMessage();
2424

25-
sender.Send(message,new SendOptions(address));
25+
sender.Send(message, new SendOptions(address));
2626

2727

2828
var received = WaitForMessage();
@@ -46,7 +46,7 @@ public void Should_be_able_to_receive_messages_without_headers()
4646

4747
properties.MessageId = message.Id;
4848

49-
channel.BasicPublish(string.Empty, address.Queue, true, false, properties, message.Body);
49+
channel.BasicPublish(string.Empty, address.Queue, true, properties, message.Body);
5050
}
5151

5252
var received = WaitForMessage();
@@ -69,13 +69,13 @@ public void Should_be_able_to_receive_a_blank_message()
6969

7070
properties.MessageId = message.Id;
7171

72-
channel.BasicPublish(string.Empty, address.Queue, true, false, properties, message.Body);
72+
channel.BasicPublish(string.Empty, address.Queue, true, properties, message.Body);
7373
}
7474

7575
var received = WaitForMessage();
7676

7777

78-
Assert.NotNull(received.Id,"The message id should be defaulted to a new guid if not set");
78+
Assert.NotNull(received.Id, "The message id should be defaulted to a new guid if not set");
7979
}
8080

8181

@@ -92,10 +92,10 @@ public void Should_up_convert_the_native_type_to_the_enclosed_message_types_head
9292
{
9393
var properties = channel.CreateBasicProperties();
9494

95-
properties.MessageId = message.Id;
95+
properties.MessageId = message.Id;
9696
properties.Type = typeName;
9797

98-
channel.BasicPublish(string.Empty, address.Queue, true, false, properties, message.Body);
98+
channel.BasicPublish(string.Empty, address.Queue, true, properties, message.Body);
9999
}
100100

101101
var received = WaitForMessage();
@@ -117,7 +117,7 @@ public void Should_listen_to_the_callback_queue_as_well()
117117

118118
properties.MessageId = message.Id;
119119

120-
channel.BasicPublish(string.Empty, address.Queue+"."+RuntimeEnvironment.MachineName, true, false, properties, message.Body);
120+
channel.BasicPublish(string.Empty, address.Queue + "." + RuntimeEnvironment.MachineName, true, properties, message.Body);
121121
}
122122

123123

src/NServiceBus.RabbitMQ.Tests/When_sending_a_message_over_rabbitmq.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public void Should_populate_the_body()
2424
[Test]
2525
public void Should_set_the_content_type()
2626
{
27-
VerifyRabbit(new TransportMessageBuilder().WithHeader(Headers.ContentType, "application/json"),
27+
VerifyRabbit(new TransportMessageBuilder().WithHeader(NServiceBus.Headers.ContentType, "application/json"),
2828
received => Assert.AreEqual("application/json", received.BasicProperties.ContentType));
2929

3030
}
@@ -45,7 +45,7 @@ public void Should_set_the_message_type_based_on_the_encoded_message_types_heade
4545
{
4646
var messageType = typeof (MyMessage);
4747

48-
VerifyRabbit(new TransportMessageBuilder().WithHeader(Headers.EnclosedMessageTypes, messageType.AssemblyQualifiedName),
48+
VerifyRabbit(new TransportMessageBuilder().WithHeader(NServiceBus.Headers.EnclosedMessageTypes, messageType.AssemblyQualifiedName),
4949
received => Assert.AreEqual(messageType.FullName, received.BasicProperties.Type));
5050

5151
}

src/NServiceBus.RabbitMQ.Tests/packages.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
<package id="NLog" version="3.2.0.0" targetFramework="net45" />
55
<package id="NServiceBus" version="5.2.0" targetFramework="net45" />
66
<package id="NUnit" version="2.6.4" targetFramework="net45" />
7-
<package id="RabbitMQ.Client" version="3.5.0" targetFramework="net45" />
7+
<package id="RabbitMQ.Client" version="3.6.1" targetFramework="net45" />
88
</packages>

src/NServiceBus.RabbitMQ/NServiceBus.RabbitMQ.csproj

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
1717
<TargetFrameworkProfile />
1818
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
19-
<NuGetPackageImportStamp>76bed58f</NuGetPackageImportStamp>
19+
<NuGetPackageImportStamp>
20+
</NuGetPackageImportStamp>
2021
</PropertyGroup>
2122
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
2223
<DebugSymbols>true</DebugSymbols>
@@ -47,22 +48,22 @@
4748
<Prefer32Bit>false</Prefer32Bit>
4849
</PropertyGroup>
4950
<ItemGroup>
50-
<Reference Include="Janitor">
51-
<HintPath>..\packages\Janitor.Fody.1.1.0.0\Lib\portable-net4+sl5+wp8+win8+wpa81+MonoAndroid16+MonoTouch40\Janitor.dll</HintPath>
51+
<Reference Include="Janitor, Version=1.1.6.0, Culture=neutral, PublicKeyToken=d34c7d3bba3746e6, processorArchitecture=MSIL">
52+
<HintPath>..\packages\Janitor.Fody.1.1.6.0\Lib\dotnet\Janitor.dll</HintPath>
5253
<Private>False</Private>
5354
</Reference>
5455
<Reference Include="Microsoft.CSharp" />
5556
<Reference Include="NServiceBus.Core, Version=5.0.0.0, Culture=neutral, PublicKeyToken=9fc386479f8a226c, processorArchitecture=MSIL">
5657
<SpecificVersion>False</SpecificVersion>
5758
<HintPath>..\packages\NServiceBus.5.2.0\lib\net45\NServiceBus.Core.dll</HintPath>
5859
</Reference>
59-
<Reference Include="Obsolete">
60-
<HintPath>..\packages\Obsolete.Fody.3.1.0.0\Lib\NET35\Obsolete.dll</HintPath>
60+
<Reference Include="Obsolete, Version=4.0.4.0, Culture=neutral, PublicKeyToken=1ca091877d12ca03, processorArchitecture=MSIL">
61+
<HintPath>..\packages\Obsolete.Fody.4.0.4\Lib\dotnet\Obsolete.dll</HintPath>
6162
<Private>False</Private>
6263
</Reference>
63-
<Reference Include="RabbitMQ.Client, Version=3.5.0.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce, processorArchitecture=MSIL">
64-
<SpecificVersion>False</SpecificVersion>
65-
<HintPath>..\packages\RabbitMQ.Client.3.5.0\lib\net40\RabbitMQ.Client.dll</HintPath>
64+
<Reference Include="RabbitMQ.Client, Version=3.6.1.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce, processorArchitecture=MSIL">
65+
<HintPath>..\packages\RabbitMQ.Client.3.6.1\lib\net45\RabbitMQ.Client.dll</HintPath>
66+
<Private>True</Private>
6667
</Reference>
6768
<Reference Include="System" />
6869
<Reference Include="System.Configuration" />
@@ -119,11 +120,11 @@
119120
<PropertyGroup>
120121
<ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
121122
</PropertyGroup>
122-
<Error Condition="!Exists('..\packages\Fody.1.26.4\build\Fody.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Fody.1.26.4\build\Fody.targets'))" />
123123
<Error Condition="!Exists('..\packages\GitVersionTask.2.0.1\Build\GitVersionTask.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\GitVersionTask.2.0.1\Build\GitVersionTask.targets'))" />
124124
<Error Condition="!Exists('..\packages\NuGetPackager.0.5.5\build\NuGetPackager.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NuGetPackager.0.5.5\build\NuGetPackager.targets'))" />
125+
<Error Condition="!Exists('..\packages\Fody.1.29.4\build\dotnet\Fody.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Fody.1.29.4\build\dotnet\Fody.targets'))" />
125126
</Target>
126-
<Import Project="..\packages\Fody.1.26.4\build\Fody.targets" Condition="Exists('..\packages\Fody.1.26.4\build\Fody.targets')" />
127127
<Import Project="..\packages\GitVersionTask.2.0.1\Build\GitVersionTask.targets" Condition="Exists('..\packages\GitVersionTask.2.0.1\Build\GitVersionTask.targets')" />
128128
<Import Project="..\packages\NuGetPackager.0.5.5\build\NuGetPackager.targets" Condition="Exists('..\packages\NuGetPackager.0.5.5\build\NuGetPackager.targets')" />
129+
<Import Project="..\packages\Fody.1.29.4\build\dotnet\Fody.targets" Condition="Exists('..\packages\Fody.1.29.4\build\dotnet\Fody.targets')" />
129130
</Project>

src/NServiceBus.RabbitMQ/PersistentConnection.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ namespace NServiceBus.Transports.RabbitMQ
22
{
33
using System;
44
using System.Collections.Generic;
5-
using System.Net;
65
using System.Threading;
76
using global::RabbitMQ.Client;
87
using global::RabbitMQ.Client.Events;
@@ -291,8 +290,6 @@ public void Dispose()
291290
readonly string purpose;
292291

293292
static readonly ILog Logger = LogManager.GetLogger(typeof (RabbitMqConnectionManager));
294-
public EndPoint LocalEndPoint { get { return connection.LocalEndPoint; }}
295-
public EndPoint RemoteEndPoint { get { return connection.RemoteEndPoint; } }
296293
public int LocalPort { get { return connection.LocalPort; } }
297294
public int RemotePort { get { return connection.RemotePort; } }
298295
}

0 commit comments

Comments
 (0)