Use analyzer-suggested null propagation

DavidBoike · DavidBoike · commit 08cfb4e5f22c · 2025-07-16T15:49:40.000-05:00
diff --git a/src/NServiceBus.RavenDB.AcceptanceTests/When_injecting_the_raven_session.cs b/src/NServiceBus.RavenDB.AcceptanceTests/When_injecting_the_raven_session.cs
@@ -42,11 +42,8 @@ await Scenario.Define<RavenSessionTestContext>()
             }
             finally
             {
-                if (session != null)
-                {
-                    session.Dispose();
-                    session = null;
-                }
+                session?.Dispose();
+                session = null;
 
                 if (documentStore != null)
                 {
diff --git a/src/NServiceBus.RavenDB.AcceptanceTests/When_raven_session_is_provided.cs b/src/NServiceBus.RavenDB.AcceptanceTests/When_raven_session_is_provided.cs
@@ -37,11 +37,8 @@ public async Task It_should_return_configured_session()
             }
             finally
             {
-                if (session != null)
-                {
-                    session.Dispose();
-                    session = null;
-                }
+                session?.Dispose();
+                session = null;
 
                 if (documentStore != null)
                 {

Original file line number	Diff line number	Diff line change
`@@ -42,11 +42,8 @@ await Scenario.Define<RavenSessionTestContext>()`
`42`	`42`	`}`
`43`	`43`	`finally`
`44`	`44`	`{`
`45`		`- if (session != null)`
`46`		`- {`
`47`		`- session.Dispose();`
`48`		`- session = null;`
`49`		`- }`
	`45`	`+ session?.Dispose();`
	`46`	`+ session = null;`
`50`	`47`
`51`	`48`	`if (documentStore != null)`
`52`	`49`	`{`
Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,8 @@ public async Task It_should_return_configured_session()`
`37`	`37`	`}`
`38`	`38`	`finally`
`39`	`39`	`{`
`40`		`- if (session != null)`
`41`		`- {`
`42`		`- session.Dispose();`
`43`		`- session = null;`
`44`		`- }`
	`40`	`+ session?.Dispose();`
	`41`	`+ session = null;`
`45`	`42`
`46`	`43`	`if (documentStore != null)`
`47`	`44`	`{`