Skip to content

Commit 9065e46

Browse files
committed
Use nullable for circuit breaker
1 parent e5b169a commit 9065e46

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/NServiceBus.Transport.Sql.Shared/Receiving/RepeatedFailuresOverTimeCircuitBreaker.cs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace NServiceBus.Transport.Sql.Shared;
1+
#nullable enable
2+
3+
namespace NServiceBus.Transport.Sql.Shared;
24

35
using System;
46
using System.Threading;
@@ -42,18 +44,18 @@ public RepeatedFailuresOverTimeCircuitBreaker(
4244
string name,
4345
TimeSpan timeToWaitBeforeTriggering,
4446
Action<Exception> triggerAction,
45-
Action armedAction = null,
46-
Action disarmedAction = null,
47-
TimeSpan timeToWaitWhenTriggered = default,
48-
TimeSpan timeToWaitWhenArmed = default)
47+
Action? armedAction = null,
48+
Action? disarmedAction = null,
49+
TimeSpan? timeToWaitWhenTriggered = default,
50+
TimeSpan? timeToWaitWhenArmed = default)
4951
{
5052
this.name = name;
5153
this.triggerAction = triggerAction;
5254
this.armedAction = armedAction ?? (static () => { });
5355
this.disarmedAction = disarmedAction ?? (static () => { });
5456
this.timeToWaitBeforeTriggering = timeToWaitBeforeTriggering;
55-
this.timeToWaitWhenTriggered = timeToWaitWhenTriggered == TimeSpan.MinValue ? TimeSpan.FromSeconds(10) : timeToWaitWhenTriggered;
56-
this.timeToWaitWhenArmed = timeToWaitWhenArmed == TimeSpan.MinValue ? TimeSpan.FromSeconds(1) : timeToWaitWhenArmed;
57+
this.timeToWaitWhenTriggered = timeToWaitWhenTriggered ?? TimeSpan.FromSeconds(10);
58+
this.timeToWaitWhenArmed = timeToWaitWhenArmed ?? TimeSpan.FromSeconds(1);
5759

5860
timer = new Timer(CircuitBreakerTriggered);
5961
}
@@ -154,7 +156,7 @@ Task Delay()
154156
/// </summary>
155157
public void Dispose() => timer.Dispose();
156158

157-
void CircuitBreakerTriggered(object state)
159+
void CircuitBreakerTriggered(object? state)
158160
{
159161
var previousState = Volatile.Read(ref circuitBreakerState);
160162
if (previousState == Disarmed)
@@ -187,7 +189,7 @@ void CircuitBreakerTriggered(object state)
187189
public bool IsTriggered => circuitBreakerState == Triggered;
188190

189191
int circuitBreakerState = Disarmed;
190-
Exception lastException;
192+
Exception? lastException;
191193

192194
readonly string name;
193195
readonly Timer timer;

0 commit comments

Comments
 (0)