Skip to content

Commit d437e40

Browse files
committed
Use nullable for circuit breaker
1 parent 7fad647 commit d437e40

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/NServiceBus.Transport.SqlServer/Receiving/RepeatedFailuresOverTimeCircuitBreaker.cs

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace NServiceBus.Transport.SqlServer;
1+
#nullable enable
2+
3+
namespace NServiceBus.Transport.SqlServer;
24

35
using System;
46
using System.Threading;
@@ -42,18 +44,18 @@ public RepeatedFailuresOverTimeCircuitBreaker(
4244
string name,
4345
TimeSpan timeToWaitBeforeTriggering,
4446
Action<Exception> triggerAction,
45-
Action armedAction = null,
46-
Action disarmedAction = null,
47-
TimeSpan timeToWaitWhenTriggered = default,
48-
TimeSpan timeToWaitWhenArmed = default)
47+
Action? armedAction = null,
48+
Action? disarmedAction = null,
49+
TimeSpan? timeToWaitWhenTriggered = default,
50+
TimeSpan? timeToWaitWhenArmed = default)
4951
{
5052
this.name = name;
5153
this.triggerAction = triggerAction;
5254
this.armedAction = armedAction ?? (static () => { });
5355
this.disarmedAction = disarmedAction ?? (static () => { });
5456
this.timeToWaitBeforeTriggering = timeToWaitBeforeTriggering;
55-
this.timeToWaitWhenTriggered = timeToWaitWhenTriggered == TimeSpan.MinValue ? TimeSpan.FromSeconds(10) : timeToWaitWhenTriggered;
56-
this.timeToWaitWhenArmed = timeToWaitWhenArmed == TimeSpan.MinValue ? TimeSpan.FromSeconds(1) : timeToWaitWhenArmed;
57+
this.timeToWaitWhenTriggered = timeToWaitWhenTriggered ?? TimeSpan.FromSeconds(10);
58+
this.timeToWaitWhenArmed = timeToWaitWhenArmed ?? TimeSpan.FromSeconds(1);
5759

5860
timer = new Timer(CircuitBreakerTriggered);
5961
}
@@ -149,7 +151,7 @@ Task Delay()
149151
}
150152
}
151153

152-
void CircuitBreakerTriggered(object state)
154+
void CircuitBreakerTriggered(object? state)
153155
{
154156
var previousState = Volatile.Read(ref circuitBreakerState);
155157
if (previousState == Disarmed)
@@ -182,7 +184,7 @@ void CircuitBreakerTriggered(object state)
182184
public bool IsTriggered => circuitBreakerState == Triggered;
183185

184186
int circuitBreakerState = Disarmed;
185-
Exception lastException;
187+
Exception? lastException;
186188

187189
readonly string name;
188190
readonly Timer timer;

0 commit comments

Comments
 (0)