Move UseTransport to extension type similar to how persistence, serializer works (#7451)

* Move UseTransport to extension type similar to how persistence, serializer etc. works

* Skip extension method
It will still fail when an extension method doesn't end with a period or is empty

* Simplify

* Add more documentation

---------

Co-authored-by: Daniel Marbach <[email protected]>

Author: danielmarbach

src/NServiceBus.Core.Tests/ApprovalFiles/APIApprovals.ApproveNServiceBus.approved.txt

@@ -274,8 +274,6 @@ namespace NServiceBus
         public NServiceBus.ConventionsBuilder Conventions() { }
         public void RegisterComponents(System.Action<Microsoft.Extensions.DependencyInjection.IServiceCollection> registration) { }
         public void SendOnly() { }
-        public NServiceBus.RoutingSettings<TTransport> UseTransport<TTransport>(TTransport transportDefinition)
-            where TTransport : NServiceBus.Transport.TransportDefinition { }
     }
     public static class EndpointConfigurationExtensions
     {
@@ -981,6 +979,18 @@ namespace NServiceBus
         public ToSagaExpression(NServiceBus.IConfigureHowToFindSagaWithMessage sagaMessageFindingConfiguration, System.Linq.Expressions.Expression<System.Func<TMessage, object?>> messageProperty) { }
         public void ToSaga(System.Linq.Expressions.Expression<System.Func<TSagaData, object?>> sagaEntityProperty) { }
     }
+    public static class TransportConfig
+    {
+        public static NServiceBus.RoutingSettings<TTransport> UseTransport<TTransport>(this NServiceBus.EndpointConfiguration endpointConfiguration, TTransport transportDefinition)
+            where TTransport :  notnull, NServiceBus.Transport.TransportDefinition { }
+        public sealed class <G>$AA4D0E78385CDABA9697E12267F940F2
+        {
+            [System.Runtime.CompilerServices.ExtensionMarker("<M>$B2E337D1C9DAD3813FD51F2C3BF89066")]
+            public NServiceBus.RoutingSettings<TTransport> UseTransport<TTransport>(TTransport transportDefinition)
+                where TTransport : NServiceBus.Transport.TransportDefinition { }
+            public static class <M>$B2E337D1C9DAD3813FD51F2C3BF89066 { }
+        }
+    }
     public class TransportExtensions<T>
         where T : NServiceBus.Transport.TransportDefinition
     {

src/NServiceBus.Core.Tests/DocumentationTests.cs

@@ -70,38 +70,11 @@ protected override void VisitElement(Element element)
 
         void AddIfEmpty(Element element)
         {
-            if (element is TypeParamRef)
-            {
-                return;
-            }
-            if (element is C)
-            {
-                return;
-            }
-            if (element is SeeAlso)
-            {
-                return;
-            }
-            if (element is UnknownElement)
-            {
-                return;
-            }
-            if (element is Code)
-            {
-                return;
-            }
-            if (element is See)
-            {
-                return;
-            }
-            if (element is Text)
-            {
-                return;
-            }
-            if (element is ParamRef)
+            if (SkipElementTypes(element))
             {
                 return;
             }
+
             var text = element.ToText();
             if (text == null)
             {
@@ -135,6 +108,13 @@ void AddIfEmpty(Element element)
             BadMembers.Add(currentMember);
         }
 
+        static bool SkipElementTypes(Element element) =>
+            element switch
+            {
+                TypeParamRef or C or SeeAlso or UnknownElement or Code or See or Text or ParamRef or ExtensionMethod => true,
+                _ => false,
+            };
+
         bool IsInheritDoc(Element element)
         {
             var lineInfoField = GetLineInfoField(element.GetType());

src/NServiceBus.Core/EndpointConfiguration.cs

@@ -9,12 +9,11 @@ namespace NServiceBus;
 using Microsoft.Extensions.DependencyInjection;
 using Pipeline;
 using Settings;
-using Transport;
 
 /// <summary>
 /// Configuration used to create an endpoint instance.
 /// </summary>
-public partial class EndpointConfiguration : ExposeSettings
+public class EndpointConfiguration : ExposeSettings
 {
     /// <summary>
     /// Initializes the endpoint configuration builder.
@@ -98,16 +97,6 @@ public ConventionsBuilder Conventions()
         return ConventionsBuilder;
     }
 
-    /// <summary>
-    /// Configures NServiceBus to use the given transport.
-    /// </summary>
-    public RoutingSettings<TTransport> UseTransport<TTransport>(TTransport transportDefinition)
-        where TTransport : TransportDefinition
-    {
-        Settings.Get<TransportSeam.Settings>().TransportDefinition = transportDefinition;
-        return new RoutingSettings<TTransport>(Settings);
-    }
-
     //This needs to be here since we have downstreams that use reflection to access this property
     internal void TypesToScanInternal(IEnumerable<Type> typesToScan)
     {

src/NServiceBus.Core/Transports/TransportConfig.cs

@@ -0,0 +1,27 @@
+#nullable enable
+
+namespace NServiceBus;
+
+using Configuration.AdvancedExtensibility;
+using Transport;
+
+/// <summary>
+/// Enables users to select the transport by calling .UseTransport().
+/// </summary>
+public static class TransportConfig
+{
+    extension(EndpointConfiguration endpointConfiguration)
+    {
+        /// <summary>
+        /// Configures NServiceBus to use the given transport.
+        /// </summary>
+        /// <typeparam name="TTransport">The transport definition eg <see cref="LearningTransport" />, AzureServiceBusTransport etc.</typeparam>
+        public RoutingSettings<TTransport> UseTransport<TTransport>(TTransport transportDefinition)
+            where TTransport : TransportDefinition
+        {
+            var settings = endpointConfiguration.GetSettings();
+            settings.Get<TransportSeam.Settings>().TransportDefinition = transportDefinition;
+            return new RoutingSettings<TTransport>(settings);
+        }
+    }
+}