Fix batch message deduplication logic to not update batch on already … #50
code-analysis.yml
on: push
code-analysis
/
code-analysis
30s
Annotations
4 errors
|
GlobalSuppressionsInEditorConfig:
_/src/RepoIntegrityTests/CodeFileTests.cs#L12
Global suppressions should be expressed in .editorconfig files so they are easily findable:
> src/ServiceControl.Transports.Tests/GlobalSuppressions.cs
|
|
ShouldDefineDefaultShell:
_/src/RepoIntegrityTests/WorkflowTests.cs#L14
Workflows should set the default shell to 'pwsh' or 'bash' ensure same functionality on all platforms, unless there are no run steps:
> .github/workflows/build-windows.yml - Job 'build' does not have a default shell defined at the workflow or job level.
> .github/workflows/ci.yml - Job 'build' does not have a default shell defined at the workflow or job level.
|
|
ShouldBeInProjectFile:
_/src/RepoIntegrityTests/InternalsVisibleToTests.cs#L35
InternalsVisibleTo should be registered in project files:
> src/ServiceControl.Config/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Config.Tests" />'
> src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.UnitTests" />'
> src/ServiceControl/InternalsVisibleTo.cs - Declares InternalsVisibleTo project 'ServiceControl.AcceptanceTests' that does not exist in the solution.
> src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTests.RavenDB" />'
> src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTesting" />'
> src/ServiceControl/InternalsVisibleTo.cs - Declares InternalsVisibleTo project 'ServiceControl.PersistenceTests' that does not exist in the solution.
> src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Persistence.Tests.RavenDB" />'
> src/ServiceControl/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.MultiInstance.AcceptanceTests" />'
> src/ServiceControl/InternalsVisibleTo.cs - Declares InternalsVisibleTo project 'ServiceControl.Persistence.RavenDb' that does not exist in the solution.
> src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests" />'
> src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.UnitTests" />'
> src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.Persistence.Tests" />'
> src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.Persistence.Tests.RavenDB" />'
> src/ServiceControlInstaller.Engine/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControlInstaller.Engine.UnitTests" />'
> src/ServiceControlInstaller.Engine/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Config.Tests" />'
> src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.UnitTests" />'
> src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Declares InternalsVisibleTo project 'ServiceControl.PersistenceTests' that does not exist in the solution.
> src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Persistence.Tests.RavenDB" />'
> src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.AcceptanceTests.RavenDB" />'
> src/ServiceControl.Persistence.RavenDB/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.MultiInstance.AcceptanceTests" />'
> src/ServiceControl.Audit/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.UnitTests" />'
> src/ServiceControl.Audit/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests" />'
> src/ServiceControl.Audit/InternalsVisibleTo.cs - Express in project file in an ItemGroup using '<InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests.RavenDB" />'
> src/ServiceControl.Audit/I
|
|
code-analysis / code-analysis
Process completed with exit code 1.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
code-analysis-warnings
Expired
|
381 Bytes |
sha256:c4c828f9d6738f508d88a435128f66f54908e5fc40beab706b25bb3b0ca501a1
|
|