Add test to check that we use corax by default

Author: andreasohlund

src/ServiceControl.Audit.Persistence.RavenDB/DatabaseSetup.cs

@@ -36,8 +36,8 @@ async Task CreateDatabase(IDocumentStore documentStore, string databaseName, Can
                 try
                 {
                     var databaseRecord = new DatabaseRecord(databaseName);
-                    databaseRecord.Settings.Add("Indexing.Auto.SearchEngineType", configuration.SearchEngineType);
-                    databaseRecord.Settings.Add("Indexing.Static.SearchEngineType", configuration.SearchEngineType);
+                    databaseRecord.Settings.Add(AutoSearchEngineTypeKey, configuration.SearchEngineType);
+                    databaseRecord.Settings.Add(StaticSearchEngineTypeKey, configuration.SearchEngineType);
 
                     await documentStore.Maintenance.Server.SendAsync(new CreateDatabaseOperation(databaseRecord), cancellationToken);
                 }
@@ -95,19 +95,19 @@ async Task UpdateDatabaseSettings(IDocumentStore documentStore, string databaseN
             }
         }
 
-        public static async Task DeleteLegacySagaDetailsIndex(IDocumentStore documentStore, CancellationToken cancellationToken)
+        internal static async Task DeleteLegacySagaDetailsIndex(IDocumentStore documentStore, CancellationToken cancellationToken)
         {
             // If the SagaDetailsIndex exists but does not have a .Take(50000), then we remove the current SagaDetailsIndex and
             // create a new one. If we do not remove the current one, then RavenDB will attempt to do a side-by-side migration.
             // Doing a side-by-side migration results in the index never swapping if there is constant ingestion as RavenDB will wait.
             // for the index to not be stale before swapping to the new index. Constant ingestion means the index will never be not-stale.
             // This needs to stay in place until the next major version as the user could upgrade from an older version of the current
             // Major (v5.x.x) which might still have the incorrect index.
-            var sagaDetailsIndexOperation = new GetIndexOperation("SagaDetailsIndex");
+            var sagaDetailsIndexOperation = new GetIndexOperation(SagaDetailsIndexName);
             var sagaDetailsIndexDefinition = await documentStore.Maintenance.SendAsync(sagaDetailsIndexOperation, cancellationToken);
             if (sagaDetailsIndexDefinition != null && !sagaDetailsIndexDefinition.Reduce.Contains("Take(50000)"))
             {
-                await documentStore.Maintenance.SendAsync(new DeleteIndexOperation("SagaDetailsIndex"), cancellationToken);
+                await documentStore.Maintenance.SendAsync(new DeleteIndexOperation(SagaDetailsIndexName), cancellationToken);
             }
         }
 
@@ -120,12 +120,12 @@ async Task CreateIndexes(IDocumentStore documentStore, CancellationToken cancell
             if (configuration.EnableFullTextSearch)
             {
                 indexList.Add(new MessagesViewIndexWithFullTextSearch());
-                await documentStore.Maintenance.SendAsync(new DeleteIndexOperation("MessagesViewIndex"), cancellationToken);
+                await documentStore.Maintenance.SendAsync(new DeleteIndexOperation(MessagesViewIndexName), cancellationToken);
             }
             else
             {
                 indexList.Add(new MessagesViewIndex());
-                await documentStore.Maintenance.SendAsync(new DeleteIndexOperation("MessagesViewIndexWithFullTextSearch"), cancellationToken);
+                await documentStore.Maintenance.SendAsync(new DeleteIndexOperation(MessagesViewIndexWithFullTextSearchIndexName), cancellationToken);
             }
 
             await IndexCreation.CreateIndexesAsync(indexList, documentStore, null, null, cancellationToken);
@@ -144,5 +144,8 @@ async Task ConfigureExpiration(IDocumentStore documentStore, CancellationToken c
 
         const string AutoSearchEngineTypeKey = "Indexing.Auto.SearchEngineType";
         const string StaticSearchEngineTypeKey = "Indexing.Static.SearchEngineType";
+        internal const string MessagesViewIndexName = "MessagesViewIndex";
+        internal const string MessagesViewIndexWithFullTextSearchIndexName = "MessagesViewIndexWithFullTextSearch";
+        internal const string SagaDetailsIndexName = "SagaDetailsIndex";
     }
 }

src/ServiceControl.Audit.Persistence.Tests.RavenDB/SagaDetailsIndexTests.cs

@@ -4,6 +4,7 @@
     using System.Threading;
     using System.Threading.Tasks;
     using NUnit.Framework;
+    using Persistence.RavenDB;
     using Raven.Client.Documents.Indexes;
     using Raven.Client.Documents.Operations.Indexes;
     using ServiceControl.SagaAudit;
@@ -14,14 +15,14 @@ class SagaDetailsIndexTests : PersistenceTestFixture
         [Test]
         public async Task Deletes_index_that_does_not_have_cap_of_50000()
         {
-            await configuration.DocumentStore.Maintenance.SendAsync(new DeleteIndexOperation("SagaDetailsIndex"));
+            await configuration.DocumentStore.Maintenance.SendAsync(new DeleteIndexOperation(DatabaseSetup.SagaDetailsIndexName));
 
             var indexWithout50000capDefinition = new IndexDefinition
             {
-                Name = "SagaDetailsIndex",
+                Name = DatabaseSetup.SagaDetailsIndexName,
                 Maps =
-                            [
-                                @"from doc in docs
+                [
+                    @"from doc in docs
                                                      select new
                                                      {
                                                          doc.SagaId,
@@ -41,7 +42,7 @@ public async Task Deletes_index_that_does_not_have_cap_of_50000()
                                     }
                                 }
             }"
-                            ],
+                ],
                 Reduce = @"from result in results
                                             group result by result.SagaId
                             into g
@@ -61,12 +62,12 @@ into g
 
             await configuration.DocumentStore.Maintenance.SendAsync(putIndexesOp);
 
-            var sagaDetailsIndexOperation = new GetIndexOperation("SagaDetailsIndex");
+            var sagaDetailsIndexOperation = new GetIndexOperation(DatabaseSetup.SagaDetailsIndexName);
             var sagaDetailsIndexDefinition = await configuration.DocumentStore.Maintenance.SendAsync(sagaDetailsIndexOperation);
 
             Assert.That(sagaDetailsIndexDefinition, Is.Not.Null);
 
-            await Persistence.RavenDB.DatabaseSetup.DeleteLegacySagaDetailsIndex(configuration.DocumentStore, CancellationToken.None);
+            await DatabaseSetup.DeleteLegacySagaDetailsIndex(configuration.DocumentStore, CancellationToken.None);
 
             sagaDetailsIndexDefinition = await configuration.DocumentStore.Maintenance.SendAsync(sagaDetailsIndexOperation);
 
@@ -76,9 +77,9 @@ into g
         [Test]
         public async Task Does_not_delete_index_that_does_have_cap_of_50000()
         {
-            await Persistence.RavenDB.DatabaseSetup.DeleteLegacySagaDetailsIndex(configuration.DocumentStore, CancellationToken.None);
+            await DatabaseSetup.DeleteLegacySagaDetailsIndex(configuration.DocumentStore, CancellationToken.None);
 
-            var sagaDetailsIndexOperation = new GetIndexOperation("SagaDetailsIndex");
+            var sagaDetailsIndexOperation = new GetIndexOperation(DatabaseSetup.SagaDetailsIndexName);
             var sagaDetailsIndexDefinition = await configuration.DocumentStore.Maintenance.SendAsync(sagaDetailsIndexOperation);
 
             Assert.That(sagaDetailsIndexDefinition, Is.Not.Null);
@@ -100,13 +101,10 @@ await IngestSagaAudits(new SagaSnapshot
 
             await configuration.CompleteDBOperation();
 
-            using (var session = configuration.DocumentStore.OpenAsyncSession())
-            {
-                var sagaDetailsIndexOperation = new GetIndexOperation("SagaDetailsIndex");
-                var sagaDetailsIndexDefinition = await configuration.DocumentStore.Maintenance.SendAsync(sagaDetailsIndexOperation);
+            var sagaDetailsIndexOperation = new GetIndexOperation(DatabaseSetup.SagaDetailsIndexName);
+            var sagaDetailsIndexDefinition = await configuration.DocumentStore.Maintenance.SendAsync(sagaDetailsIndexOperation);
 
-                Assert.That(sagaDetailsIndexDefinition.Reduce, Does.Contain("Take(50000)"), "The SagaDetails index definition does not contain a .Take(50000) to limit the number of saga state changes that are reduced by the map/reduce");
-            }
+            Assert.That(sagaDetailsIndexDefinition.Reduce, Does.Contain("Take(50000)"), "The SagaDetails index definition does not contain a .Take(50000) to limit the number of saga state changes that are reduced by the map/reduce");
         }
 
         async Task IngestSagaAudits(params SagaSnapshot[] snapshots)
@@ -116,6 +114,7 @@ async Task IngestSagaAudits(params SagaSnapshot[] snapshots)
             {
                 await unitOfWork.RecordSagaSnapshot(snapshot);
             }
+
             await unitOfWork.DisposeAsync();
             await configuration.CompleteDBOperation();
         }

src/ServiceControl.Audit.Persistence.Tests.RavenDB/SearchEngineTypeTests.cs

@@ -0,0 +1,20 @@
+namespace ServiceControl.Audit.Persistence.Tests;
+
+using System.Threading.Tasks;
+using NUnit.Framework;
+using Persistence.RavenDB;
+using Raven.Client.Documents.Indexes;
+using Raven.Client.Documents.Operations.Indexes;
+
+[TestFixture]
+class SearchEngineTypeTests : PersistenceTestFixture
+{
+    [Test]
+    public async Task Free_text_search_should_be_on_using_corax_by_default()
+    {
+        var index = await configuration.DocumentStore.Maintenance.SendAsync(new GetIndexStatisticsOperation(DatabaseSetup.MessagesViewIndexWithFullTextSearchIndexName));
+
+        Assert.That(index, Is.Not.Null);
+        Assert.That(index.SearchEngineType, Is.EqualTo(SearchEngineType.Corax));
+    }
+}