Update src/ServiceControl/Recoverability/Grouping/Groupers/ExceptionTypeAndStackTraceFailureClassifier.cs

soujay · ngallegos · web-flow · commit 099d98ad0da4 · 2025-04-07T14:17:40.000-07:00
Co-authored-by: Nick Gallegos &lt;nicholas.gallegos@gmail.com&gt;
diff --git a/src/ServiceControl/Recoverability/Grouping/Groupers/ExceptionTypeAndStackTraceFailureClassifier.cs b/src/ServiceControl/Recoverability/Grouping/Groupers/ExceptionTypeAndStackTraceFailureClassifier.cs
@@ -47,7 +47,7 @@ public string ClassifyFailure(ClassifiableMessageDetails failure)
             }
             catch (RegexMatchTimeoutException)
             {
-                return GetNonStandardClassification(exception.ExceptionType);
+                // Intentionally empty - if the parsing fails, treat it as if exception.Message is null or empty, not throw an exception
             }
 
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public string ClassifyFailure(ClassifiableMessageDetails failure)`
`47`	`47`	`}`
`48`	`48`	`catch (RegexMatchTimeoutException)`
`49`	`49`	`{`
`50`		`- return GetNonStandardClassification(exception.ExceptionType);`
	`50`	`+ // Intentionally empty - if the parsing fails, treat it as if exception.Message is null or empty, not throw an exception`
`51`	`51`	`}`
`52`	`52`
`53`	`53`