SentTime no longer required

Also added tests for missing IsSystemMessage

Author: andreasohlund

src/ServiceControl.AcceptanceTests/MessageFailures/When_a_message_has_failed_from_send_only_endpoint.cs

@@ -1,7 +1,6 @@
 namespace ServiceBus.Management.AcceptanceTests
 {
     using System;
-    using System.Runtime.Remoting.Contexts;
     using Contexts;
     using NServiceBus;
     using NServiceBus.AcceptanceTesting;

src/ServiceControl.UnitTests/CompositeViews/FailedMessageTest.cs

@@ -0,0 +1,94 @@
+namespace ServiceControl.UnitTests.CompositeViews
+{
+    using System;
+    using System.Collections.Generic;
+    using System.Linq;
+    using System.Threading;
+    using Infrastructure.RavenDB;
+    using MessageFailures;
+    using NUnit.Framework;
+    using Raven.Client;
+    using ServiceControl.MessageFailures.Api;
+
+    [TestFixture]
+    public class FailedMessagesTests : TestWithRavenDB
+    {
+        [Test]
+        public void Should_allow_errors_with_no_metadata()
+        {
+            using (var session = documentStore.OpenSession())
+            {
+                var processedMessage = new FailedMessage
+                                       {
+                                           Id = "1",
+                                           UniqueMessageId = "xyz",
+                                           Status = FailedMessageStatus.Unresolved,
+                                           ProcessingAttempts = new List<FailedMessage.ProcessingAttempt> { new FailedMessage.ProcessingAttempt
+                                           {
+                                               AttemptedAt = DateTime.UtcNow,
+                                               MessageMetadata = new Dictionary<string, object>()
+                                           }}
+                                       };
+
+                session.Store(processedMessage);
+
+                session.SaveChanges();
+            }
+
+            RavenQueryStatistics stats;
+
+            do
+            {
+                using (var session = documentStore.OpenSession())
+                {
+
+
+                    var results = session.Advanced.LuceneQuery<FailedMessageViewIndex.SortAndFilterOptions, FailedMessageViewIndex>()
+                                        .SetResultTransformer(new FailedMessageViewTransformer().TransformerName)
+                                        .Statistics(out stats)
+                                            .SelectFields<FailedMessageView>()
+                                        .ToList();
+
+
+                    if (!stats.IsStale)
+                    {
+                        Console.Out.WriteLine("Checking result");
+                        Assert.AreEqual(1, results.Count);
+
+                        Assert.AreEqual(DateTime.MinValue,results.First().TimeSent);
+                    }
+                }
+
+
+
+                if (stats.IsStale)
+                    Thread.Sleep(1000);
+
+            } while (stats.IsStale);
+
+
+        }
+
+
+        [SetUp]
+        public void SetUp()
+        {
+            documentStore = InMemoryStoreBuilder.GetInMemoryStore();
+
+            var customIndex = new FailedMessageViewIndex();
+            customIndex.Execute(documentStore);
+
+            var transformer = new FailedMessageViewTransformer();
+
+            transformer.Execute(documentStore);
+        }
+
+        [TearDown]
+        public void TearDown()
+        {
+            documentStore.Dispose();
+        }
+
+        IDocumentStore documentStore;
+    }
+}

src/ServiceControl.UnitTests/ServiceControl.UnitTests.csproj

@@ -89,6 +89,7 @@
     <Reference Include="System.Xml.Linq" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="CompositeViews\FailedMessageTest.cs" />
     <Compile Include="ExternalIntegrations\MessageFailedConverterTests.cs" />
     <Compile Include="CompositeViews\MessagesViewTests.cs" />
     <Compile Include="Expiration\CustomExpirationBundleTests.cs" />

src/ServiceControl/MessageFailures/Api/FailedMessageViewTransformer.cs

@@ -1,5 +1,6 @@
 namespace ServiceControl.MessageFailures.Api
 {
+    using System;
     using System.Linq;
     using Raven.Client.Indexes;
 
@@ -16,7 +17,7 @@ public FailedMessageViewTransformer()
                     IsSystemMessage = (bool)rec.MessageMetadata["IsSystemMessage"],
                     SendingEndpoint = rec.MessageMetadata["SendingEndpoint"],
                     ReceivingEndpoint = rec.MessageMetadata["ReceivingEndpoint"],
-                    TimeSent = rec.MessageMetadata["TimeSent"],
+                    TimeSent = (DateTime)rec.MessageMetadata["TimeSent"],
                     MessageId = rec.MessageMetadata["MessageId"],
                     rec.FailureDetails.Exception,
                     NumberOfProcessingAttempts = failure.ProcessingAttempts.Count(),