avoid array allocations for string split (#4895)

Author: SimonCropp

src/ServiceControl.UnitTests/API/APIApprovals.cs

@@ -150,7 +150,7 @@ string RemoveDataStoreSettings(string json)
 
             foreach (var settingLine in settingsLines)
             {
-                var parts = settingLine.Split(new[] { ':' }, StringSplitOptions.RemoveEmptyEntries);
+                var parts = settingLine.Split(':', StringSplitOptions.RemoveEmptyEntries);
                 var settingName = parts[0].Trim('"', ' ');
 
                 if (dataStoreSettings.Contains(settingName) == false)

src/ServiceControl/ExternalIntegrations/RemoveVersionInformationBehavior.cs

@@ -11,7 +11,7 @@ public override Task Invoke(IOutgoingPhysicalMessageContext context, Func<Task>
         {
             if (context.Headers.TryGetValue(NServiceBus.Headers.EnclosedMessageTypes, out var typeHeader))
             {
-                var types = typeHeader.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries);
+                var types = typeHeader.Split(';', StringSplitOptions.RemoveEmptyEntries);
 
                 var typesWithoutVersionInfo = string.Join(";", types.Select(x => RemoveVersionAndKeyInformation(x)));