Replace hardcoded config file names with constants in unit tests to fix teardown issue (#5252)

Author: ramonsmits

src/ServiceControl.Audit.UnitTests/PopulateAppSettingsTests.cs

@@ -10,6 +10,8 @@ namespace ServiceControl.UnitTests;
 [TestFixture]
 public class PopulateAppSettingsTests
 {
+    const string ConfigFileName = "ServiceControl.Audit.exe.config";
+
     [Test]
     public async Task Should_populate_appSettings_from_exe_config_file()
     {
@@ -24,7 +26,7 @@ public async Task Should_populate_appSettings_from_exe_config_file()
                       </configuration>
                       """;
 
-        await File.WriteAllTextAsync("ServiceControl.Audit.exe.config", config);
+        await File.WriteAllTextAsync(ConfigFileName, config);
 
         var fileName = "ServiceControl.Audit";
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
@@ -70,5 +72,5 @@ public async Task Should_populate_appSettings_from_exe_config_file()
     }
 
     [TearDown]
-    public void TearDown() => File.Delete("ServiceControl.exe.config");
+    public void TearDown() => File.Delete(ConfigFileName);
 }

src/ServiceControl.Monitoring.UnitTests/PopulateAppSettingsTests.cs

@@ -10,6 +10,8 @@ namespace ServiceControl.UnitTests;
 [TestFixture]
 public class PopulateAppSettingsTests
 {
+    const string ConfigFileName = "ServiceControl.Monitoring.exe.config";
+
     [Test]
     public async Task Should_populate_appSettings_from_exe_config_file()
     {
@@ -24,7 +26,7 @@ public async Task Should_populate_appSettings_from_exe_config_file()
                       </configuration>
                       """;
 
-        await File.WriteAllTextAsync("ServiceControl.Monitoring.exe.config", config);
+        await File.WriteAllTextAsync(ConfigFileName, config);
 
         var fileName = "ServiceControl.Monitoring";
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
@@ -74,5 +76,5 @@ public async Task Should_populate_appSettings_from_exe_config_file()
     }
 
     [TearDown]
-    public void TearDown() => File.Delete("ServiceControl.exe.config");
+    public void TearDown() => File.Delete(ConfigFileName);
 }

src/ServiceControl.UnitTests/PopulateAppSettingsTests.cs

@@ -10,6 +10,8 @@ namespace ServiceControl.UnitTests;
 [TestFixture]
 public class PopulateAppSettingsTests
 {
+    const string ConfigFileName = "ServiceControl.exe.config";
+
     [Test]
     public async Task Should_populate_appSettings_from_exe_config_file()
     {
@@ -24,7 +26,7 @@ public async Task Should_populate_appSettings_from_exe_config_file()
                       </configuration>
                       """;
 
-        await File.WriteAllTextAsync("ServiceControl.exe.config", config);
+        await File.WriteAllTextAsync(ConfigFileName, config);
 
         var fileName = "ServiceControl";
         if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
@@ -72,5 +74,5 @@ public async Task Should_populate_appSettings_from_exe_config_file()
     }
 
     [TearDown]
-    public void TearDown() => File.Delete("ServiceControl.exe.config");
+    public void TearDown() => File.Delete(ConfigFileName);
 }