Check exceptions

Author: andreasohlund

src/ServiceControlInstaller.Engine.UnitTests/Setup/SetupInstanceTests.cs

@@ -1,11 +1,20 @@
 namespace ServiceControlInstaller.Engine.UnitTests.Setup;
 
+using System;
 using Engine.Setup;
 using NUnit.Framework;
 
 [TestFixture]
 public class SetupInstanceTests
 {
     [Test]
-    public void Should_not_throw_on_0_exit_code() => Assert.DoesNotThrow(() => InstanceSetup.Run(TestContext.CurrentContext.WorkDirectory, "SetupProcessFake.exe", "test", false));
+    public void Should_not_throw_on_0_exit_code() => Assert.DoesNotThrow(() => InstanceSetup.Run(TestContext.CurrentContext.WorkDirectory, "SetupProcessFake.exe", "test", ""));
+
+    [Test]
+    public void Should_capture_and_rethrow_failures()
+    {
+        var ex = Assert.Throws<Exception>(() => InstanceSetup.Run(TestContext.CurrentContext.WorkDirectory, "SetupProcessFake.exe", "test", "fail"));
+
+        Assert.That(ex.Message, Does.Contain("Fake exception"));
+    }
 }

src/ServiceControlInstaller.Engine/Setup/InstanceSetup.cs

@@ -25,7 +25,7 @@ public static void Run(IMonitoringInstance instance) =>
             instance.Name,
             instance.SkipQueueCreation);
 
-    internal static void Run(string installPath, string exeName, string instanceName, bool skipQueueCreation)
+    static void Run(string installPath, string exeName, string instanceName, bool skipQueueCreation)
     {
         var args = $"--setup";
 
@@ -34,6 +34,11 @@ internal static void Run(string installPath, string exeName, string instanceName
             args += " --skip-queue-creation";
         }
 
+        Run(installPath, exeName, instanceName, args);
+    }
+
+    internal static void Run(string installPath, string exeName, string instanceName, string args)
+    {
         var processStartupInfo = new ProcessStartInfo
         {
             CreateNoWindow = true,

src/SetupProcessFake/Program.cs

@@ -1,3 +1,4 @@
-// See https://aka.ms/new-console-template for more information
-
-Console.WriteLine("Hello, World!");
+if (args.Any(a => a == "fail"))
+{
+    throw new Exception("Fake exception");
+}