Repo cleanup (#4483)

* Remove trailing whitespace

* Clean up app.config files

* Sort ProjectReferences

* Remove unused property

Author: bording

src/ProjectReferences.Transports.props

@@ -5,9 +5,9 @@
     <ProjectReference Include="..\ServiceControl.Transports.ASQ\ServiceControl.Transports.ASQ.csproj" ReferenceOutputAssembly="false" Private="false" />
     <ProjectReference Include="..\ServiceControl.Transports.Learning\ServiceControl.Transports.Learning.csproj" ReferenceOutputAssembly="false" Private="false" />
     <ProjectReference Include="..\ServiceControl.Transports.Msmq\ServiceControl.Transports.Msmq.csproj" ReferenceOutputAssembly="false" Private="false" SkipGetTargetFrameworkProperties="true" UndefineProperties="TargetFramework" />
+    <ProjectReference Include="..\ServiceControl.Transports.PostgreSql\ServiceControl.Transports.PostgreSql.csproj" ReferenceOutputAssembly="false" Private="false" />
     <ProjectReference Include="..\ServiceControl.Transports.RabbitMQ\ServiceControl.Transports.RabbitMQ.csproj" ReferenceOutputAssembly="false" Private="false" />
     <ProjectReference Include="..\ServiceControl.Transports.SqlServer\ServiceControl.Transports.SqlServer.csproj" ReferenceOutputAssembly="false" Private="false" />
-    <ProjectReference Include="..\ServiceControl.Transports.PostgreSql\ServiceControl.Transports.PostgreSql.csproj" ReferenceOutputAssembly="false" Private="false" />
     <ProjectReference Include="..\ServiceControl.Transports.SQS\ServiceControl.Transports.SQS.csproj" ReferenceOutputAssembly="false" Private="false" />
   </ItemGroup>
 

src/ServiceControl.Audit/App.config

@@ -15,9 +15,9 @@ These settings are only here so that we can debug ServiceControl while developin
     <!--<add key="ServiceControl.Audit/TransportType" value="AzureStorageQueue" />-->
     <!--<add key="ServiceControl.Audit/TransportType" value="MSMQ" />-->
     <!--<add key="ServiceControl.Audit/TransportType" value="NetStandardAzureServiceBus" />-->
+    <!--<add key="ServiceControl.Audit/TransportType" value="PostgreSQL" />-->
     <!--<add key="ServiceControl.Audit/TransportType" value="RabbitMQ.QuorumConventionalRouting" />-->
     <!--<add key="ServiceControl.Audit/TransportType" value="SQLServer" />-->
-    <!--<add key="ServiceControl.Audit/TransportType" value="PostgreSQL" />-->
 
     <!-- DEVS - Pick a persistence to run Auditing instance on. -->
     <add key="ServiceControl.Audit/PersistenceType" value="InMemory" />
@@ -42,13 +42,13 @@ These settings are only here so that we can debug ServiceControl while developin
     <!--NetStandardAzureServiceBus -->
     <!--<add name="NServiceBus/Transport" connectionString="Endpoint=sb://[namespace].servicebus.windows.net; SharedSecretIssuer=;SharedSecretValue=;QueueLengthQueryDelayInterval=;TopicName=default-is-bundle-1" />-->
 
+    <!--PostgreSQL -->
+    <!--<add name="NServiceBus/Transport" connectionString="Server=;Database=nservicebus;Port=5432;User Id=;Password=" />-->
+
     <!--RabbitMQ.QuorumConventionalRouting -->
     <!--<add name="NServiceBus/Transport" connectionString="host=;username=;password=" />-->
 
     <!--SQLServer -->
     <!--<add name="NServiceBus/Transport" connectionString="Data Source=;Initial Catalog=nservicebus;Integrated Security=True;Queue Schema=myschema;Subscriptions Table=tablename@schema@catalog" />-->
-
-    <!--PostgreSQL -->
-    <!--<add name="NServiceBus/Transport" connectionString="Server=;Database=nservicebus;Port=5432;User Id=;Password=;" />-->
   </connectionStrings>
 </configuration>

src/ServiceControl.Monitoring/App.config

@@ -15,10 +15,10 @@ These settings are only here so that we can debug ServiceControl while developin
     <!--<add key="Monitoring/TransportType" value="AzureStorageQueue" />-->
     <!--<add key="Monitoring/TransportType" value="MSMQ" />-->
     <!--<add key="Monitoring/TransportType" value="NetStandardAzureServiceBus" />-->
+    <!--<add key="Monitoring/TransportType" value="PostgreSQL" />-->
     <!--<add key="Monitoring/TransportType" value="RabbitMQ.QuorumConventionalRouting" />-->
     <!--<add key="Monitoring/TransportType" value="SQLServer" />-->
-    <!--<add key="Monitoring/TransportType" value="PostgreSQL" />-->
-    
+
   </appSettings>
   <connectionStrings>
     <!-- DEVS - Pick a transport connection string to match chosen transport above -->
@@ -39,13 +39,13 @@ These settings are only here so that we can debug ServiceControl while developin
     <!--NetStandardAzureServiceBus -->
     <!--<add name="NServiceBus/Transport" connectionString="Endpoint=sb://[namespace].servicebus.windows.net; SharedSecretIssuer=;SharedSecretValue=;QueueLengthQueryDelayInterval=;TopicName=default-is-bundle-1" />-->
 
+    <!--PostgreSQL -->
+    <!--<add name="NServiceBus/Transport" connectionString="Server=;Database=nservicebus;Port=5432;User Id=;Password=" />-->
+
     <!--RabbitMQ.QuorumConventionalRouting -->
     <!--<add name="NServiceBus/Transport" connectionString="host=;username=;password=" />-->
 
     <!--SQLServer -->
     <!--<add name="NServiceBus/Transport" connectionString="Data Source=;Initial Catalog=nservicebus;Integrated Security=True;Queue Schema=myschema;Subscriptions Table=tablename@schema@catalog" />-->
-
-    <!--PostgreSQL -->
-    <!--<add name="NServiceBus/Transport" connectionString="Server=;Database=nservicebus;Port=5432;User Id=;Password=;" />-->
   </connectionStrings>
 </configuration>

src/ServiceControl/App.config

@@ -18,9 +18,9 @@ These settings are only here so that we can debug ServiceControl while developin
     <!--<add key="ServiceControl/TransportType" value="AzureStorageQueue" />-->
     <!--<add key="ServiceControl/TransportType" value="MSMQ" />-->
     <!--<add key="ServiceControl/TransportType" value="NetStandardAzureServiceBus" />-->
+    <!--<add key="ServiceControl/TransportType" value="PostgreSQL" />-->
     <!--<add key="ServiceControl/TransportType" value="RabbitMQ.QuorumConventionalRouting" />-->
     <!--<add key="ServiceControl/TransportType" value="SQLServer" />-->
-    <!--<add key="ServiceControl/TransportType" value="PostgreSQL" />-->
 
     <add key="ServiceControl/PersistenceType" value="RavenDB" />
   </appSettings>
@@ -43,13 +43,13 @@ These settings are only here so that we can debug ServiceControl while developin
     <!--NetStandardAzureServiceBus -->
     <!--<add name="NServiceBus/Transport" connectionString="Endpoint=sb://[namespace].servicebus.windows.net; SharedSecretIssuer=;SharedSecretValue=;QueueLengthQueryDelayInterval=;TopicName=default-is-bundle-1" />-->
 
+    <!--PostgreSQL -->
+    <!--<add name="NServiceBus/Transport" connectionString="Server=;Database=nservicebus;Port=5432;User Id=;Password=" />-->
+
     <!--RabbitMQ.QuorumConventionalRouting -->
     <!--<add name="NServiceBus/Transport" connectionString="host=;username=;password=" />-->
 
     <!--SQLServer -->
     <!--<add name="NServiceBus/Transport" connectionString="Data Source=;Initial Catalog=nservicebus;Integrated Security=True;Queue Schema=myschema;Subscriptions Table=tablename@schema@catalog" />-->
-    
-    <!--PostgreSQL -->
-    <!--<add name="NServiceBus/Transport" connectionString="Server=;Database=nservicebus;Port=5432;User Id=;Password=;" />-->
   </connectionStrings>
 </configuration>

src/ServiceControlInstaller.Packaging/ServiceControlInstaller.Packaging.csproj

@@ -26,7 +26,6 @@
     <Audit>Particular.ServiceControl.Audit</Audit>
     <Monitoring>Particular.ServiceControl.Monitoring</Monitoring>
     <InstanceShared>InstanceShared</InstanceShared>
-    <Transports>Transports</Transports>
     <RavenDBServer>RavenDBServer</RavenDBServer>
   </PropertyGroup>