Check that server major/minor is higher than client major/minor

Author: ramonsmits

src/ServiceControl.RavenDB/ServiceControl.RavenDB.csproj

@@ -9,6 +9,7 @@
     <PackageReference Include="ByteSize" />
     <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" />
     <PackageReference Include="NServiceBus" />
+    <PackageReference Include="NuGet.Versioning" />
     <PackageReference Include="RavenDB.Embedded" />
   </ItemGroup>
 

src/ServiceControl.RavenDB/StartupChecks.cs

@@ -2,6 +2,7 @@
 {
     using System.Reflection;
     using System.Threading;
+    using NuGet.Versioning;
     using Raven.Client.Documents;
     using Raven.Client.ServerWide.Operations;
 
@@ -11,14 +12,16 @@ public static async Task EnsureServerVersion(IDocumentStore store, CancellationT
         {
             var build = await store.Maintenance.Server.SendAsync(new GetBuildNumberOperation(), cancellationToken);
 
-            var clientVersion = typeof(Raven.Client.Constants).Assembly.GetCustomAttributes<AssemblyInformationalVersionAttribute>().First().InformationalVersion;
-            var parts = clientVersion.Split('.');
-            var clientProductVersion = $"{parts[0]}.{parts[1]}";
+            var clientVersion = SemanticVersion.Parse(typeof(Raven.Client.Constants).Assembly.GetCustomAttributes<AssemblyInformationalVersionAttribute>().First().InformationalVersion);
+            var serverVersion = NuGetVersion.Parse(build.ProductVersion);
 
-            if (clientProductVersion != build.ProductVersion)
+            var serverHasLowerMajorMinor = serverVersion.Major < clientVersion.Major
+                                || (serverVersion.Major == clientVersion.Major && serverVersion.Minor < clientVersion.Minor);
+
+            if (serverHasLowerMajorMinor)
             {
-                throw new Exception($"ServiceControl expects RavenDB Server version {clientProductVersion} but the server is using {build.ProductVersion}.");
+                throw new Exception($"ServiceControl expects at minimum RavenDB Server version {clientVersion.Major}.{clientVersion.Minor} but the server is using {build.ProductVersion}.");
             }
         }
     }
-}
+}