Skip to content

Commit 6869fc1

Browse files
another attempt to fix the tests
1 parent e3aa362 commit 6869fc1

File tree

2 files changed

+32
-2
lines changed

2 files changed

+32
-2
lines changed

src/ServiceControl.AcceptanceTests/Recoverability/ExternalIntegration/When_a_failed_edit_is_resolved_by_retry.cs

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,30 @@ namespace ServiceControl.AcceptanceTests.Recoverability.ExternalIntegration
1515
class When_a_failed_edit_is_resolved_by_retry : ExternalIntegrationAcceptanceTest
1616
{
1717
[Test]
18-
[Ignore("Isolating another test")]
1918
public async Task Should_publish_notification()
2019
{
20+
CustomConfiguration = config => config.OnEndpointSubscribed<EditMessageResolutionContext>((s, ctx) =>
21+
{
22+
ctx.ExternalProcessorSubscribed = s.SubscriberReturnAddress.Contains(nameof(MessageReceiver));
23+
});
24+
2125
var context = await Define<EditMessageResolutionContext>()
2226
.WithEndpoint<MessageReceiver>(b => b.When(async (bus, c) =>
2327
{
2428
await bus.Subscribe<MessageFailureResolvedByRetry>();
29+
30+
if (c.HasNativePubSubSupport)
31+
{
32+
c.ExternalProcessorSubscribed = true;
33+
}
2534
}).When(c => c.SendLocal(new EditResolutionMessage())).DoNotFailOnErrorMessages())
2635
.Done(async ctx =>
2736
{
37+
if (!ctx.ExternalProcessorSubscribed)
38+
{
39+
return false;
40+
}
41+
2842
if (!ctx.OriginalMessageHandled)
2943
{
3044
return false;
@@ -109,6 +123,7 @@ public class EditMessageResolutionContext : ScenarioContext
109123
public bool EditedAndRetriedMessage { get; set; }
110124
public bool RetriedMessage { get; set; }
111125
public string EditedMessageEditOf { get; set; }
126+
public bool ExternalProcessorSubscribed { get; set; }
112127
}
113128

114129
public class MessageReceiver : EndpointConfigurationBuilder

src/ServiceControl.AcceptanceTests/Recoverability/ExternalIntegration/When_a_reedit_solves_a_failed_msg.cs

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,31 @@ namespace ServiceControl.AcceptanceTests.Recoverability.ExternalIntegration
1515
class When_a_reedit_solves_a_failed_msg : AcceptanceTest
1616
{
1717
[Test]
18-
[Ignore("Isolating another test")]
1918
public async Task Should_publish_notification()
2019
{
20+
CustomConfiguration = config => config.OnEndpointSubscribed<EditMessageResolutionContext>((s, ctx) =>
21+
{
22+
ctx.ExternalProcessorSubscribed = s.SubscriberReturnAddress.Contains(nameof(MessageReceiver));
23+
});
24+
2125
var context = await Define<EditMessageResolutionContext>()
2226
.WithEndpoint<MessageReceiver>(b => b.When(async (bus, c) =>
2327
{
2428
await bus.Subscribe<MessageFailureResolvedByRetry>();
29+
30+
if (c.HasNativePubSubSupport)
31+
{
32+
c.ExternalProcessorSubscribed = true;
33+
}
2534
}).When(c => c.SendLocal(new EditResolutionMessage() { MessageAttempt = 0 }))
2635
.DoNotFailOnErrorMessages())
2736
.Done(async ctx =>
2837
{
38+
if (!ctx.ExternalProcessorSubscribed)
39+
{
40+
return false;
41+
}
42+
2943
if (!ctx.OriginalMessageHandled)
3044
{
3145
return false;
@@ -124,6 +138,7 @@ public class EditMessageResolutionContext : ScenarioContext
124138
public string SecondMessageFailureId { get; set; }
125139
public string EditedMessageEditOf2 { get; set; }
126140
public string EditedMessageEditOf1 { get; set; }
141+
public bool ExternalProcessorSubscribed { get; set; }
127142
}
128143

129144
public class MessageReceiver : EndpointConfigurationBuilder

0 commit comments

Comments
 (0)