Skip to content

Commit 754ee52

Browse files
fix attempt
1 parent 0c3d770 commit 754ee52

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/ServiceControl.AcceptanceTests/Recoverability/ExternalIntegration/ExternalIntegrationAcceptanceTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public ErrorSender() =>
2121
{
2222
c.NoDelayedRetries();
2323
//TODO: Get back to this to determine whether or not this duplication for simulating the production code is really needed
24-
//c.ReportSuccessfulRetriesToServiceControl();
24+
c.ReportSuccessfulRetriesToServiceControl();
2525
});
2626

2727
public class AHandler : IHandleMessages<AMessage>

src/ServiceControl.AcceptanceTests/Recoverability/ExternalIntegration/When_a_failed_msg_is_resolved_by_edit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace ServiceControl.AcceptanceTests.Recoverability.ExternalIntegration
1313
using ServiceControl.MessageFailures.Api;
1414
using JsonSerializer = System.Text.Json.JsonSerializer;
1515

16-
class When_a_failed_msg_is_resolved_by_edit : ExternalIntegrationAcceptanceTest
16+
class When_a_failed_msg_is_resolved_by_edit : AcceptanceTest
1717
{
1818
[Test]
1919
public async Task Should_publish_notification()

src/ServiceControl/MessageFailures/Handlers/LegacyMessageFailureResolvedHandler.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
/// This class handles legacy messages that mark a failed message as successfully retried. For further details go to message definitions.
1212
/// </summary>
1313
class LegacyMessageFailureResolvedHandler :
14-
IHandleMessages<MarkMessageFailureResolvedByRetry>,
15-
IHandleMessages<MessageFailureResolvedByRetry>
14+
IHandleMessages<MarkMessageFailureResolvedByRetry>
15+
// IHandleMessages<MessageFailureResolvedByRetry>
1616
{
1717
public LegacyMessageFailureResolvedHandler(IErrorMessageDataStore store, IDomainEvents domainEvents)
1818
{
@@ -31,15 +31,15 @@ await domainEvents.Raise(new MessageFailureResolvedByRetry
3131
}
3232

3333
// This is only needed because we might get this from legacy not yet converted instances
34-
public async Task Handle(MessageFailureResolvedByRetry message, IMessageHandlerContext context)
35-
{
36-
await MarkAsResolvedByRetry(message.FailedMessageId, message.AlternativeFailedMessageIds);
37-
await domainEvents.Raise(new MessageFailureResolvedByRetry
38-
{
39-
AlternativeFailedMessageIds = message.AlternativeFailedMessageIds,
40-
FailedMessageId = message.FailedMessageId
41-
}, context.CancellationToken);
42-
}
34+
// public async Task Handle(MessageFailureResolvedByRetry message, IMessageHandlerContext context)
35+
// {
36+
// await MarkAsResolvedByRetry(message.FailedMessageId, message.AlternativeFailedMessageIds);
37+
// await domainEvents.Raise(new MessageFailureResolvedByRetry
38+
// {
39+
// AlternativeFailedMessageIds = message.AlternativeFailedMessageIds,
40+
// FailedMessageId = message.FailedMessageId
41+
// }, context.CancellationToken);
42+
// }
4343

4444
async Task MarkAsResolvedByRetry(string primaryId, string[] messageAlternativeFailedMessageIds)
4545
{

0 commit comments

Comments
 (0)