Skip to content

Commit 7616151

Browse files
committed
Set instance id
1 parent 7f37e53 commit 7616151

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

src/Directory.Packages.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
<PackageVersion Include="NUnit" Version="4.3.2" />
5151
<PackageVersion Include="NUnit.Analyzers" Version="4.6.0" />
5252
<PackageVersion Include="NUnit3TestAdapter" Version="4.6.0" />
53-
<PackageVersion Include="OpenTelemetry.Exporter.Console" Version="1.9.0" />
5453
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.9.0" />
5554
<PackageVersion Include="OpenTelemetry.Extensions.Hosting" Version="1.9.0" />
5655
<PackageVersion Include="Particular.Approvals" Version="2.0.1" />

src/ServiceControl.Audit/HostApplicationBuilderExtensions.cs

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,11 @@ public static void AddServiceControlAudit(this IHostApplicationBuilder builder,
2929
Settings settings,
3030
EndpointConfiguration configuration)
3131
{
32+
var version = FileVersionInfo.GetVersionInfo(typeof(HostApplicationBuilderExtensions).Assembly.Location).ProductVersion;
3233
var persistenceConfiguration = PersistenceConfigurationFactory.LoadPersistenceConfiguration(settings);
3334
var persistenceSettings = persistenceConfiguration.BuildPersistenceSettings(settings);
3435

35-
RecordStartup(settings, configuration, persistenceConfiguration);
36+
RecordStartup(version, settings, configuration, persistenceConfiguration);
3637

3738
builder.Logging.ClearProviders();
3839
builder.Logging.AddNLog();
@@ -69,18 +70,22 @@ public static void AddServiceControlAudit(this IHostApplicationBuilder builder,
6970

7071
if (!string.IsNullOrEmpty(settings.OtelMetricsUrl))
7172
{
73+
if (!Uri.TryCreate(settings.OtelMetricsUrl, UriKind.Absolute, out var otelMetricsUri))
74+
{
75+
throw new UriFormatException($"Invalid OtelMetricsUrl: {settings.OtelMetricsUrl}");
76+
}
7277
builder.Services.AddOpenTelemetry()
73-
.ConfigureResource(b => b.AddService(serviceName: settings.InstanceName))
78+
.ConfigureResource(b => b.AddService(
79+
serviceName: "Particular.ServiceControl.Audit",
80+
serviceVersion: version,
81+
serviceInstanceId: settings.InstanceName))
7482
.WithMetrics(b =>
7583
{
7684
b.AddMeter("ServiceControl");
77-
7885
b.AddOtlpExporter(e =>
7986
{
80-
e.Endpoint = new Uri(settings.OtelMetricsUrl);
87+
e.Endpoint = otelMetricsUri;
8188
});
82-
83-
b.AddConsoleExporter();
8489
});
8590
}
8691

@@ -100,10 +105,8 @@ public static void AddServiceControlAuditInstallers(this IHostApplicationBuilder
100105
builder.Services.AddInstaller(persistenceSettings, persistenceConfiguration);
101106
}
102107

103-
static void RecordStartup(Settings settings, EndpointConfiguration endpointConfiguration, IPersistenceConfiguration persistenceConfiguration)
108+
static void RecordStartup(string version, Settings settings, EndpointConfiguration endpointConfiguration, IPersistenceConfiguration persistenceConfiguration)
104109
{
105-
var version = FileVersionInfo.GetVersionInfo(typeof(HostApplicationBuilderExtensions).Assembly.Location).ProductVersion;
106-
107110
var startupMessage = $@"
108111
-------------------------------------------------------------
109112
ServiceControl Audit Version: {version}

src/ServiceControl.Audit/ServiceControl.Audit.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<PackageReference Include="NServiceBus.CustomChecks" />
2929
<PackageReference Include="NServiceBus.Extensions.Hosting" />
3030
<PackageReference Include="NServiceBus.Extensions.Logging" />
31-
<PackageReference Include="OpenTelemetry.Exporter.Console" />
3231
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" />
3332
<PackageReference Include="OpenTelemetry.Extensions.Hosting" />
3433
</ItemGroup>

0 commit comments

Comments
 (0)