A few small updates

Author: johnsimons

src/ServiceControl.Persistence.Sql.Core/Implementation/CustomChecksDataStore.cs

@@ -71,7 +71,7 @@ public async Task<QueryResult<IList<CustomCheck>>> GetStats(PagingInfo paging, s
         {
             query = query.Where(c => c.Status == (int)Status.Fail);
         }
-        else if (status == "pass")
+        if (status == "pass")
         {
             query = query.Where(c => c.Status == (int)Status.Pass);
         }
@@ -109,12 +109,7 @@ public async Task DeleteCustomCheck(Guid id)
         using var scope = serviceProvider.CreateScope();
         var dbContext = scope.ServiceProvider.GetRequiredService<ServiceControlDbContextBase>();
 
-        var customCheck = await dbContext.CustomChecks.FirstOrDefaultAsync(c => c.Id == id);
-        if (customCheck != null)
-        {
-            dbContext.CustomChecks.Remove(customCheck);
-            await dbContext.SaveChangesAsync();
-        }
+        await dbContext.CustomChecks.Where(c => c.Id == id).ExecuteDeleteAsync();
     }
 
     public async Task<int> GetNumberOfFailedChecks()

src/ServiceControl.Persistence.Sql.Core/Implementation/EventLogDataStore.cs

@@ -69,7 +69,7 @@ public async Task Add(EventLogItem logItem)
             RelatedTo = entity.RelatedTo != null ? JsonSerializer.Deserialize<List<string>>(entity.RelatedTo) : null
         }).ToList();
 
-        // Version could be based on the latest RaisedAt timestamp
+        // Version could be based on the latest RaisedAt timestampn but the paging can affect this result, given that the latest may not be retrieved
         var version = entities.Any() ? entities.Max(e => e.RaisedAt).Ticks.ToString() : "0";
 
         return (items, total, version);