Use seconds as unit for duration

Author: andreasohlund

src/ServiceControl.Audit/Auditing/Metrics/BatchMetrics.cs

@@ -25,7 +25,7 @@ public void Dispose()
         }
 
         tags.Add("result", result);
-        BatchDuration.Record(sw.ElapsedMilliseconds, tags);
+        BatchDuration.Record(sw.Elapsed.TotalSeconds, tags);
     }
 
     public void Complete(int size) => actualBatchSize = size;

src/ServiceControl.Audit/Auditing/Metrics/IngestionMetrics.cs

@@ -15,9 +15,9 @@ public IngestionMetrics(IMeterFactory meterFactory)
     {
         var meter = meterFactory.Create(MeterName, MeterVersion);
 
-        batchDuration = meter.CreateHistogram<double>(CreateInstrumentName("batch_duration"), unit: "ms", "Average audit message batch processing duration");
+        batchDuration = meter.CreateHistogram<double>(CreateInstrumentName("batch_duration"), unit: "seconds", "Average audit message batch processing duration");
+        ingestionDuration = meter.CreateHistogram<double>(CreateInstrumentName("message_duration"), unit: "seconds", description: "Average incoming audit message processing duration");
         consecutiveBatchFailureGauge = meter.CreateObservableGauge(CreateInstrumentName("consecutive_batch_failures"), () => consecutiveBatchFailures, description: "Consecutive audit ingestion batch failure");
-        ingestionDuration = meter.CreateHistogram<double>(CreateInstrumentName("duration"), unit: "ms", description: "Average incoming audit message processing duration");
         failureCounter = meter.CreateCounter<long>(CreateInstrumentName("failure_count"), description: "Audit ingestion failure count");
     }
 

src/ServiceControl.Audit/Auditing/Metrics/MessageMetrics.cs

@@ -16,7 +16,7 @@ public void Dispose()
         var tags = IngestionMetrics.GetMessageTags(Context.Headers);
 
         tags.Add("result", result);
-        Duration.Record(sw.ElapsedMilliseconds, tags);
+        Duration.Record(sw.Elapsed.TotalSeconds, tags);
     }
 
     string result = "failed";

src/ServiceControl.Audit/HostApplicationBuilderExtensions.cs

@@ -27,7 +27,7 @@ namespace ServiceControl.Audit;
 
 static class HostApplicationBuilderExtensions
 {
-    static string InstanceVersion = FileVersionInfo.GetVersionInfo(typeof(HostApplicationBuilderExtensions).Assembly.Location).ProductVersion;
+    static readonly string InstanceVersion = FileVersionInfo.GetVersionInfo(typeof(HostApplicationBuilderExtensions).Assembly.Location).ProductVersion;
 
     public static void AddServiceControlAudit(this IHostApplicationBuilder builder,
         Func<ICriticalErrorContext, CancellationToken, Task> onCriticalError,