fixing broken implementation for ips

Author: Christian

src/ServiceControl.Config/UI/InstanceEdit/MonitoringEditViewModelValidator.cs

@@ -12,10 +12,6 @@ public MonitoringEditViewModelValidator()
                 .NotEmpty()
                 .When(x => x.SubmitAttempted);
 
-            RuleFor(x => x.HostName)
-                .NotEmpty()
-                .When(x => x.SubmitAttempted);
-
             RuleFor(x => x.PortNumber)
                 .NotEmpty()
                 .ValidPort()

src/ServiceControl.Config/UI/SharedInstanceEditor/SharedMonitoringEditorViewModelValidator.cs

@@ -9,8 +9,7 @@ protected SharedMonitoringEditorViewModelValidator()
         {
             RuleFor(x => x.HostName)
                 .NotEmpty()
-                .ValidHostname()
-                .When(x => x.SubmitAttempted);
+                .ValidHostname(); // Removed the .When(x => x.SubmitAttempted) condition
 
             RuleFor(x => x.LogPath)
                 .NotEmpty()

src/ServiceControl.Config/Validation/Validations.cs

@@ -205,9 +205,16 @@ public static IRuleBuilderOptions<T, string> MustBeUniqueWindowsServiceName<T>(t
         public static IRuleBuilderOptions<T, string> ValidHostname<T>(this IRuleBuilder<T, string> ruleBuilder)
         {
             return ruleBuilder.Must((t, hostname) =>
-                    !string.IsNullOrWhiteSpace(hostname) &&
-                    Uri.CheckHostName(hostname) == UriHostNameType.Dns)
-                .WithMessage(MSG_INVALID_HOSTNAME);
+            {
+                if (string.IsNullOrWhiteSpace(hostname))
+                {
+                    return false;
+                }
+
+                var hostNameType = Uri.CheckHostName(hostname);
+                return hostNameType is UriHostNameType.Dns or UriHostNameType.IPv4 or UriHostNameType.IPv6;
+            })
+            .WithMessage(MSG_INVALID_HOSTNAME);
         }
 
         public const string MSG_EMAIL_NOT_VALID = "Not Valid.";