Logging must not use string interpolation and no period at end:

1. Logging not using string interpolation to support structured logging removing the needs for IsWarnEnabled and IsInfoEnabled

2. Removed period at end of log lines as by convention.

Author: ramonsmits

src/ServiceControl.Audit/Auditing/AuditIngestor.cs

@@ -72,10 +72,7 @@ public async Task Ingest(List<MessageContext> contexts)
                         Log.Debug($"Forwarding {stored.Count} messages");
                     }
                     await Forward(stored, logQueueAddress);
-                    if (Log.IsDebugEnabled)
-                    {
-                        Log.Debug("Forwarded messages");
-                    }
+                    Log.Debug("Forwarded messages");
                 }
 
                 foreach (var context in contexts)

src/ServiceControl.Audit/Auditing/AuditPersister.cs

@@ -44,7 +44,7 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
 
             if (Logger.IsDebugEnabled)
             {
-                Logger.Debug($"Batch size {contexts.Count}");
+                Logger.DebugFormat("Batch size {0}", contexts.Count);
             }
 
             var storedContexts = new List<MessageContext>(contexts.Count);
@@ -84,10 +84,7 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
                             RecordKnownEndpoints(receivingEndpoint, knownEndpoints, processedMessage);
                         }
 
-                        if (Logger.IsDebugEnabled)
-                        {
-                            Logger.Debug("Adding audit message for bulk storage");
-                        }
+                        Logger.Debug("Adding audit message for bulk storage");
 
                         using (auditBulkInsertDurationMeter.Measure())
                         {
@@ -98,10 +95,7 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
                     }
                     else if (context.Extensions.TryGet(out SagaSnapshot sagaSnapshot))
                     {
-                        if (Logger.IsDebugEnabled)
-                        {
-                            Logger.Debug("Adding SagaSnapshot message for bulk storage");
-                        }
+                        Logger.Debug("Adding SagaSnapshot message for bulk storage");
 
                         using (sagaAuditBulkInsertDurationMeter.Measure())
                         {
@@ -116,20 +110,14 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
 
                 foreach (var endpoint in knownEndpoints.Values)
                 {
-                    if (Logger.IsDebugEnabled)
-                    {
-                        Logger.Debug($"Adding known endpoint '{endpoint.Name}' for bulk storage");
-                    }
+                    Logger.DebugFormat("Adding known endpoint '{0}' for bulk storage", endpoint.Name);
 
                     await unitOfWork.RecordKnownEndpoint(endpoint);
                 }
             }
             catch (Exception e)
             {
-                if (Logger.IsWarnEnabled)
-                {
-                    Logger.Warn("Bulk insertion failed", e);
-                }
+                Logger.Warn("Bulk insertion failed", e);
 
                 // making sure to rethrow so that all messages get marked as failed
                 throw;
@@ -138,10 +126,7 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
             {
                 if (unitOfWork != null)
                 {
-                    if (Logger.IsDebugEnabled)
-                    {
-                        Logger.Debug("Performing bulk session dispose");
-                    }
+                    Logger.Debug("Performing bulk session dispose");
 
                     try
                     {
@@ -153,10 +138,7 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
                     }
                     catch (Exception e)
                     {
-                        if (Logger.IsWarnEnabled)
-                        {
-                            Logger.Warn("Bulk insertion dispose failed", e);
-                        }
+                        Logger.Warn("Bulk insertion dispose failed", e);
 
                         // making sure to rethrow so that all messages get marked as failed
                         throw;
@@ -168,9 +150,9 @@ public async Task<IReadOnlyList<MessageContext>> Persist(IReadOnlyList<MessageCo
                 }
 
                 stopwatch.Stop();
-                if (Logger.IsDebugEnabled)
+                if (Logger.IsDebugEnabled) // Access to stopwatch and context is not cheap
                 {
-                    Logger.Debug($"Batch size {contexts.Count} took {stopwatch.ElapsedMilliseconds} ms");
+                    Logger.DebugFormat("Batch size {0} took {1} ms", contexts.Count, stopwatch.ElapsedMilliseconds);
                 }
             }
 
@@ -223,9 +205,9 @@ void ProcessSagaAuditMessage(MessageContext context)
             }
             catch (Exception e)
             {
-                if (Logger.IsWarnEnabled)
+                if (Logger.IsWarnEnabled)  // Can't use WarnFormat due to passing exception
                 {
-                    Logger.Warn($"Processing of saga audit message '{context.NativeMessageId}' failed.", e);
+                    Logger.Warn($"Processing of saga audit message '{context.NativeMessageId}' failed", e);
                 }
 
                 // releasing the failed message context early so that they can be retried outside the current batch
@@ -262,10 +244,8 @@ async Task ProcessAuditMessage(MessageContext context)
 
                 var auditMessage = new ProcessedMessage(context.Headers, new Dictionary<string, object>(metadata));
 
-                if (Logger.IsDebugEnabled)
-                {
-                    Logger.Debug($"Emitting {commandsToEmit.Count} commands and {messagesToEmit.Count} control messages.");
-                }
+                Logger.DebugFormat("Emitting {0} commands and {1} control messages", commandsToEmit.Count, messagesToEmit.Count);
+
                 foreach (var commandToEmit in commandsToEmit)
                 {
                     await messageSession.Send(commandToEmit);
@@ -274,10 +254,7 @@ async Task ProcessAuditMessage(MessageContext context)
                 await messageDispatcher.Value.Dispatch(new TransportOperations(messagesToEmit.ToArray()),
                     new TransportTransaction()); //Do not hook into the incoming transaction
 
-                if (Logger.IsDebugEnabled)
-                {
-                    Logger.Debug($"{commandsToEmit.Count} commands and {messagesToEmit.Count} control messages emitted.");
-                }
+                Logger.DebugFormat("{0} commands and {1} control messages emitted", commandsToEmit.Count, messagesToEmit.Count);
 
                 if (metadata.TryGetValue("SendingEndpoint", out var sendingEndpoint))
                 {
@@ -294,9 +271,9 @@ await messageDispatcher.Value.Dispatch(new TransportOperations(messagesToEmit.To
             }
             catch (Exception e)
             {
-                if (Logger.IsWarnEnabled)
+                if (Logger.IsWarnEnabled) // Can't use WarnFormat due to passing exception
                 {
-                    Logger.Warn($"Processing of message '{messageId}' failed.", e);
+                    Logger.Warn($"Processing of message '{messageId}' failed", e);
                 }
 
                 // releasing the failed message context early so that they can be retried outside the current batch