Skip interlocked increment

andreasohlund · andreasohlund · commit 9426ea9d5758 · 2025-02-07T15:22:50.000+01:00
diff --git a/src/ServiceControl.Audit/Auditing/AuditIngestion.cs b/src/ServiceControl.Audit/Auditing/AuditIngestion.cs
@@ -222,7 +222,7 @@ async Task Loop()
                         await auditIngestor.Ingest(contexts);
                     }
 
-                    consecutiveBatchFailuresCounter.Record(Interlocked.Exchange(ref consecutiveBatchFailures, 0));
+                    consecutiveBatchFailuresCounter.Record(0);
                 }
                 catch (OperationCanceledException)
                 {
@@ -242,7 +242,8 @@ async Task Loop()
                         context.GetTaskCompletionSource().TrySetException(e);
                     }
 
-                    consecutiveBatchFailuresCounter.Record(Interlocked.Increment(ref consecutiveBatchFailures));
+                    // no need to do interlocked increment since this is running sequential
+                    consecutiveBatchFailuresCounter.Record(consecutiveBatchFailures++);
                 }
                 finally
                 {

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ async Task Loop()`
`222`	`222`	`await auditIngestor.Ingest(contexts);`
`223`	`223`	`}`
`224`	`224`
`225`		`- consecutiveBatchFailuresCounter.Record(Interlocked.Exchange(ref consecutiveBatchFailures, 0));`
	`225`	`+ consecutiveBatchFailuresCounter.Record(0);`
`226`	`226`	`}`
`227`	`227`	`catch (OperationCanceledException)`
`228`	`228`	`{`
`@@ -242,7 +242,8 @@ async Task Loop()`
`242`	`242`	`context.GetTaskCompletionSource().TrySetException(e);`
`243`	`243`	`}`
`244`	`244`
`245`		`- consecutiveBatchFailuresCounter.Record(Interlocked.Increment(ref consecutiveBatchFailures));`
	`245`	`+ // no need to do interlocked increment since this is running sequential`
	`246`	`+ consecutiveBatchFailuresCounter.Record(consecutiveBatchFailures++);`
`246`	`247`	`}`
`247`	`248`	`finally`
`248`	`249`	`{`