File tree Expand file tree Collapse file tree 2 files changed +9
-4
lines changed
ServiceControl.Audit.Persistence.RavenDB
ServiceControl.Persistence.RavenDB Expand file tree Collapse file tree 2 files changed +9
-4
lines changed Original file line number Diff line number Diff line change @@ -8,9 +8,11 @@ namespace ServiceControl.Audit.Persistence.RavenDB;
88
99class MemoryInformationRetriever ( DatabaseConfiguration databaseConfiguration )
1010{
11- // TODO what does a connection string look like? Is it only a URI or could it contain other stuff?
12- // The ?? operator is needed because ServerUrl is populated when running embedded and connection string when running in external mode.
13- // However the tricky part is that when tests are run they behave like if it was external mode
11+ // What does a connection string look like? Is it only a URI or could it contain other stuff?
12+ // The ?? operator is needed because ServerUrl is populated when running embedded and connection
13+ // string when running in external mode. However, the tricky part is that when tests are run they
14+ // behave like if it was external mode. If the connection string contain always only the server
15+ // URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
1416 readonly HttpClient client = new ( ) { BaseAddress = new Uri ( databaseConfiguration . ServerConfiguration . ServerUrl ?? databaseConfiguration . ServerConfiguration . ConnectionString ) } ;
1517
1618 record ResponseDto
Original file line number Diff line number Diff line change @@ -8,7 +8,10 @@ namespace ServiceControl.Persistence.RavenDB;
88
99class MemoryInformationRetriever ( RavenPersisterSettings persisterSettings )
1010{
11- // TODO what does a connection string look like? Is it only a URI or could it contain other stuff?
11+ // What does a connection string look like? Is it only a URI or could it contain other stuff?
12+ // The primary instance has only the concept of a connection string (vs the Audit instance having
13+ // both a ServiceUrl and a ConnectionString). If the connection string contain always only the
14+ // server URL, this code is safe, otherwise it need to be adjusted to extract the server URL.
1215 readonly HttpClient client = new ( ) { BaseAddress = new Uri ( persisterSettings . ConnectionString ) } ;
1316
1417 record ResponseDto
You can’t perform that action at this time.
0 commit comments