Add a to-do

mauroservienti · mauroservienti · commit 99cb66680ea0 · 2025-03-10T21:20:43.000+01:00
diff --git a/src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs b/src/ServiceControl.Audit.Persistence.RavenDB/CustomChecks/CheckDirtyMemory.cs
@@ -35,6 +35,7 @@ public override async Task<CheckResult> PerformCheck(CancellationToken cancellat
             Log.Debug("Not enough dirty memory data in the series to calculate a trend.");
         }
 
+        // TODO do we need a threshold below which the check never fails?
         // Three means we'll be observing for 15 minutes before calculating the trend
         if (lastDirtyMemoryReads.Count >= 3 && AnalyzeTrendUsingRegression(lastDirtyMemoryReads) == TrendDirection.Increasing)
         {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ public override async Task<CheckResult> PerformCheck(CancellationToken cancellat`
`35`	`35`	`Log.Debug("Not enough dirty memory data in the series to calculate a trend.");`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ // TODO do we need a threshold below which the check never fails?`
`38`	`39`	`// Three means we'll be observing for 15 minutes before calculating the trend`
`39`	`40`	`if (lastDirtyMemoryReads.Count >= 3 && AnalyzeTrendUsingRegression(lastDirtyMemoryReads) == TrendDirection.Increasing)`
`40`	`41`	`{`