Apply suggestions from Daniel's code review

Co-authored-by: Daniel Marbach <[email protected]>

Author: 2 people

src/ServiceControl.Audit.Persistence.RavenDB/IRavenPersistenceLifecycle.cs

@@ -6,6 +6,6 @@
     interface IRavenPersistenceLifecycle
     {
         Task Initialize(CancellationToken cancellationToken = default);
-        Task Stop(CancellationToken cancellationToken);
+        Task Stop(CancellationToken cancellationToken = default);
     }
 }

src/ServiceControl.Audit.Persistence.RavenDB/RavenEmbeddedPersistenceLifecycle.cs

@@ -72,7 +72,7 @@ public async Task Initialize(CancellationToken cancellationToken = default)
             }
         }
 
-        public Task Stop(CancellationToken cancellationToken) => database!.Stop(cancellationToken);
+        public Task Stop(CancellationToken cancellationToken = default) => database!.Stop(cancellationToken);
 
         public void Dispose()
         {

src/ServiceControl.Audit.Persistence.RavenDB/RavenExternalPersistenceLifecycle.cs

@@ -64,7 +64,7 @@ public async Task Initialize(CancellationToken cancellationToken = default)
             }
         }
 
-        public Task Stop(CancellationToken cancellationToken) => Task.CompletedTask; // We are not stopping an external instance
+        public Task Stop(CancellationToken cancellationToken = default) => Task.CompletedTask; // We are not stopping an external instance
 
         public void Dispose() => documentStore?.Dispose();