Skip to content

Commit a076352

Browse files
committed
Replace usage of NullLogger with LoggerFactory with console output in AmazonSQSQueryTests
1 parent 6971fb1 commit a076352

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

src/Directory.Packages.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
<PackageVersion Include="Microsoft.Extensions.Logging" Version="8.0.1" />
2828
<PackageVersion Include="Microsoft.Extensions.Logging.Configuration" Version="8.0.1" />
2929
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.3" />
30+
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="8.0.1" />
3031
<PackageVersion Include="Microsoft.Extensions.TimeProvider.Testing" Version="8.10.0" />
3132
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
3233
<PackageVersion Include="Microsoft-WindowsAPICodePack-Shell" Version="1.1.5" />

src/ServiceControl.Transports.SQS.Tests/AmazonSQSQueryTests.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace ServiceControl.Transport.Tests;
66
using System.Linq;
77
using System.Threading;
88
using System.Threading.Tasks;
9-
using Microsoft.Extensions.Logging.Abstractions;
9+
using Microsoft.Extensions.Logging;
1010
using Microsoft.Extensions.Time.Testing;
1111
using NUnit.Framework;
1212
using Particular.Approvals;
@@ -35,7 +35,9 @@ public void Initialise()
3535
MaxConcurrency = 1,
3636
EndpointName = Guid.NewGuid().ToString("N")
3737
};
38-
query = new AmazonSQSQuery(NullLogger<AmazonSQSQuery>.Instance, provider, transportSettings);
38+
var loggerFactory = LoggerFactory.Create(builder => builder.AddSimpleConsole().SetMinimumLevel(LogLevel.Trace));
39+
var logger = loggerFactory.CreateLogger<AmazonSQSQuery>();
40+
query = new AmazonSQSQuery(logger, provider, transportSettings);
3941
}
4042

4143
[Test]
@@ -125,7 +127,7 @@ public async Task RunScenario()
125127

126128
query.Initialize(dictionary.AsReadOnly());
127129

128-
DateTime startDate = provider.GetUtcNow().DateTime;
130+
var startDate = DateOnly.FromDateTime(provider.GetUtcNow().DateTime);
129131
provider.Advance(TimeSpan.FromDays(1));
130132

131133
while (!TestContext.CurrentContext.CancellationToken.IsCancellationRequested)
@@ -147,7 +149,7 @@ public async Task RunScenario()
147149

148150
long total = 0L;
149151

150-
await foreach (QueueThroughput queueThroughput in query.GetThroughputPerDay(queue, DateOnly.FromDateTime(startDate), TestContext.CurrentContext.CancellationToken))
152+
await foreach (QueueThroughput queueThroughput in query.GetThroughputPerDay(queue, startDate, TestContext.CurrentContext.CancellationToken))
151153
{
152154
total += queueThroughput.TotalThroughput;
153155
}

src/ServiceControl.Transports.SQS.Tests/ServiceControl.Transports.SQS.Tests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
<ItemGroup>
1515
<PackageReference Include="GitHubActionsTestLogger" />
16+
<PackageReference Include="Microsoft.Extensions.Logging.Console" />
1617
<PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" />
1718
<PackageReference Include="Microsoft.NET.Test.Sdk" />
1819
<PackageReference Include="NServiceBus.AcceptanceTesting" />

0 commit comments

Comments
 (0)