Wire up settings that apparently have been lost

Author: bording

src/ServiceControl.Transports.RabbitMQ/QueueLengthProvider.cs

@@ -2,7 +2,6 @@
 {
     using System;
     using System.Collections.Concurrent;
-    using System.Data.Common;
     using System.Threading;
     using System.Threading.Tasks;
     using global::RabbitMQ.Client;
@@ -109,13 +108,14 @@ public void Initialize()
                 var connectionConfiguration =
                     ConnectionConfiguration.Create(connectionString, "ServiceControl.Monitoring");
 
-                var dbConnectionStringBuilder = new DbConnectionStringBuilder { ConnectionString = connectionString };
+                // TODO Fix this up
+                //var dbConnectionStringBuilder = new DbConnectionStringBuilder { ConnectionString = connectionString };
 
                 connectionFactory = new ConnectionFactory("ServiceControl.Monitoring",
                     connectionConfiguration,
                     null, //providing certificates is not supported yet
-                    dbConnectionStringBuilder.GetBooleanValue("DisableRemoteCertificateValidation"),
-                    dbConnectionStringBuilder.GetBooleanValue("UseExternalAuthMechanism"),
+                    false,//dbConnectionStringBuilder.GetBooleanValue("DisableRemoteCertificateValidation"),
+                    false, //dbConnectionStringBuilder.GetBooleanValue("UseExternalAuthMechanism"),
                     null, // value would come from config API in actual transport
                     null); // value would come from config API in actual transport
             }

src/ServiceControl.Transports.RabbitMQ/RabbitMQTransportExtensions.cs

@@ -19,10 +19,10 @@ public static void SetCustomSettingsFromConnectionString(this RabbitMQTransport
             .OfType<KeyValuePair<string, object>>()
             .ToDictionary(pair => pair.Key, pair => pair.Value.ToString(), StringComparer.OrdinalIgnoreCase);
 
-        if (dictionary.TryGetValue("ValidateDeliveryLimits", out var validateString))
+        if (dictionary.TryGetValue("ValidateDeliveryLimits", out var validateDeliveryLimitsString))
         {
-            _ = bool.TryParse(validateString, out var validate);
-            transport.ValidateDeliveryLimits = validate;
+            _ = bool.TryParse(validateDeliveryLimitsString, out var validateDeliveryLimits);
+            transport.ValidateDeliveryLimits = validateDeliveryLimits;
         }
 
         if (dictionary.TryGetValue("ManagementApiUrl", out var url))
@@ -36,5 +36,17 @@ public static void SetCustomSettingsFromConnectionString(this RabbitMQTransport
                 transport.ManagementApiConfiguration = new(url);
             }
         }
+
+        if (dictionary.TryGetValue("DisableRemoteCertificateValidation", out var disableRemoteCertificateValidationString))
+        {
+            _ = bool.TryParse(disableRemoteCertificateValidationString, out var disableRemoteCertificateValidation);
+            transport.ValidateRemoteCertificate = !disableRemoteCertificateValidation;
+        }
+
+        if (dictionary.TryGetValue("UseExternalAuthMechanism", out var useExternalAuthMechanismString))
+        {
+            _ = bool.TryParse(useExternalAuthMechanismString, out var useExternalAuthMechanism);
+            transport.UseExternalAuthMechanism = useExternalAuthMechanism;
+        }
     }
 }