Adjust to auto property

Author: danielmarbach

src/ServiceControl.Audit/Infrastructure/Settings/Settings.cs

@@ -139,16 +139,16 @@ public int MaxBodySizeToStore
         {
             get
             {
-                if (maxBodySizeToStore <= 0)
+                if (field <= 0)
                 {
                     logger.LogError("MaxBodySizeToStore settings is invalid, 1 is the minimum value. Defaulting to {MaxBodySizeToStoreDefault}", MaxBodySizeToStoreDefault);
                     return MaxBodySizeToStoreDefault;
                 }
 
-                return maxBodySizeToStore;
+                return field;
             }
-            set => maxBodySizeToStore = value;
-        }
+            set;
+        } = SettingsReader.Read(SettingsRootNamespace, "MaxBodySizeToStore", MaxBodySizeToStoreDefault);
 
         public string InstanceName { get; init; } = DEFAULT_INSTANCE_NAME;
 
@@ -290,9 +290,6 @@ static string Subscope(string address)
 
         // logger is intentionally not static to prevent it from being initialized before LoggingConfigurator.ConfigureLogging has been called
         readonly ILogger logger = LoggerUtil.CreateStaticLogger<Settings>();
-
-        int maxBodySizeToStore = SettingsReader.Read(SettingsRootNamespace, "MaxBodySizeToStore", MaxBodySizeToStoreDefault);
-
         public const string DEFAULT_INSTANCE_NAME = "Particular.ServiceControl.Audit";
         public static readonly SettingsRootNamespace SettingsRootNamespace = new("ServiceControl.Audit");
 

src/ServiceControl/CompositeViews/Messages/ScatterGatherRemoteOnly.cs

@@ -16,8 +16,6 @@ public abstract class ScatterGatherRemoteOnly<TIn, TOut>(Settings settings, IHtt
 
     public sealed class NoOpStore
     {
-        public static NoOpStore Instance => instance ??= new NoOpStore();
-
-        static NoOpStore instance;
+        public static NoOpStore Instance => field ??= new NoOpStore();
     }
 }

src/ServiceControl/Infrastructure/Settings/Settings.cs

@@ -109,17 +109,16 @@ public string RootUrl
 
         public string ApiUrl => $"{RootUrl}api";
 
-        string _instanceId;
         public string InstanceId
         {
             get
             {
-                if (string.IsNullOrEmpty(_instanceId))
+                if (string.IsNullOrEmpty(field))
                 {
-                    _instanceId = InstanceIdGenerator.FromApiUrl(ApiUrl);
+                    field = InstanceIdGenerator.FromApiUrl(ApiUrl);
                 }
 
-                return _instanceId;
+                return field;
             }
         }
 

src/ServiceControl/Recoverability/Retrying/Infrastructure/ErrorQueueNameCache.cs

@@ -4,19 +4,17 @@
 
 class ErrorQueueNameCache
 {
-    string resolvedErrorAddress;
-
     public string ResolvedErrorAddress
     {
         get
         {
-            if (string.IsNullOrEmpty(resolvedErrorAddress))
+            if (string.IsNullOrEmpty(field))
             {
                 throw new InvalidOperationException($"{nameof(ResolvedErrorAddress)} is not set. Please set it before accessing.");
             }
 
-            return resolvedErrorAddress;
+            return field;
         }
-        set => resolvedErrorAddress = value;
+        set;
     }
 }