Update the RabbitMQ prereq prompts

Author: bording

src/ServiceControl.Config/Commands/ScmuCommandChecks.cs

@@ -21,7 +21,7 @@ protected override async Task<bool> PromptForRabbitMqCheck(bool isUpgrade)
         {
             var title = isUpgrade ? "UPGRADE WARNING" : "INSTALL WARNING";
             var beforeWhat = isUpgrade ? "upgrading" : "installing";
-            var message = $"ServiceControl version {Constants.CurrentVersion} requires RabbitMQ broker version 3.10.0 or higher. Also, the stream_queue and quorum_queue feature flags must be enabled on the broker. Please confirm your broker meets the minimum requirements before {beforeWhat}.";
+            var message = $"ServiceControl version {Constants.CurrentVersion} requires:\n• RabbitMQ broker version 3.10.0 or higher\n• The stream_queue and quorum_queue feature flags must be enabled\n• The management plugin must be enabled\n\nPlease confirm your broker meets the minimum requirements before {beforeWhat}.";
             var question = "Do you want to proceed?";
             var yes = "Yes, my RabbitMQ broker meets the minimum requirements";
             var no = "No, cancel the install";

src/ServiceControl.Management.PowerShell/Validation/AcknowledgementValues.cs

@@ -3,5 +3,6 @@
     static class AcknowledgementValues
     {
         public const string RabbitMQBrokerVersion310 = "RabbitMQBrokerVersion310";
+        public const string RabbitMQManagementApi = "RabbitMQManagementApi";
     }
 }

src/ServiceControl.Management.PowerShell/Validation/PowerShellCommandChecks.cs

@@ -71,15 +71,23 @@ protected override Task NotifyForMissingSystemPrerequisites(string missingPrereq
 
         protected override Task<bool> PromptForRabbitMqCheck(bool isUpgrade)
         {
-            if (acknowledgements.Any(ack => ack.Equals(AcknowledgementValues.RabbitMQBrokerVersion310, StringComparison.OrdinalIgnoreCase)))
+            if (!acknowledgements.Any(ack => ack.Equals(AcknowledgementValues.RabbitMQBrokerVersion310, StringComparison.OrdinalIgnoreCase)))
             {
-                return Task.FromResult(true);
+                var terminateMsg = $"ServiceControl version {Constants.CurrentVersion} requires RabbitMQ broker version 3.10.0 or higher. Also, the stream_queue and quorum_queue feature flags must be enabled on the broker. Use -Acknowledgements {AcknowledgementValues.RabbitMQBrokerVersion310} if you are sure your broker meets these requirements.";
+
+                Terminate(terminateMsg, "Install Error", ErrorCategory.InvalidArgument);
+                return Task.FromResult(false);
             }
 
-            var terminateMsg = $"ServiceControl version {Constants.CurrentVersion} requires RabbitMQ broker version 3.10.0 or higher. Also, the stream_queue and quorum_queue feature flags must be enabled on the broker. Use -Acknowledgements {AcknowledgementValues.RabbitMQBrokerVersion310} if you are sure your broker meets these requirements.";
+            if (!acknowledgements.Any(ack => ack.Equals(AcknowledgementValues.RabbitMQManagementApi, StringComparison.OrdinalIgnoreCase)))
+            {
+                var terminateMsg = $"ServiceControl version {Constants.CurrentVersion} requires that the management plugin be enabled and the management API be accessible. Use -Acknowledgements {AcknowledgementValues.RabbitMQManagementApi} if you are sure your broker meets these requirements.";
 
-            Terminate(terminateMsg, "Install Error", ErrorCategory.InvalidArgument);
-            return Task.FromResult(false);
+                Terminate(terminateMsg, "Install Error", ErrorCategory.InvalidArgument);
+                return Task.FromResult(false);
+            }
+
+            return Task.FromResult(true);
         }
 
         protected override Task<bool> PromptToStopRunningInstance(BaseService instance)

src/ServiceControlInstaller.Engine/Validation/AbstractCommandChecks.cs

@@ -4,6 +4,7 @@
     using System.Linq;
     using System.ServiceProcess;
     using System.Threading.Tasks;
+    using NuGet.Versioning;
     using ServiceControl.LicenseManagement;
     using ServiceControlInstaller.Engine.Configuration.ServiceControl;
     using ServiceControlInstaller.Engine.Instances;
@@ -46,7 +47,7 @@ public async Task<bool> ValidateNewInstance(params IServiceInstance[] instances)
                 .Select(i => i.TransportPackage)
                 .First(t => t is not null);
 
-            var continueInstall = await RabbitMqCheckIsOK(transport, false).ConfigureAwait(false);
+            var continueInstall = await RabbitMqCheckIsOK(transport, Constants.CurrentVersion, false).ConfigureAwait(false);
 
             return continueInstall;
         }
@@ -81,22 +82,19 @@ async Task<bool> CanEditOrDelete(BaseService instance, bool isDelete)
             return true;
         }
 
-        async Task<bool> RabbitMqCheckIsOK(TransportInfo transport, bool isUpgrade)
+        async Task<bool> RabbitMqCheckIsOK(TransportInfo transport, SemanticVersion instanceVersion, bool isUpgrade)
         {
-            if (transport is null)
-            {
-                throw new ArgumentNullException(nameof(transport));
-            }
+            ArgumentNullException.ThrowIfNull(transport);
 
             if (transport.ZipName != "RabbitMQ")
             {
                 // not Rabbit, don't care
                 return true;
             }
 
-            // Only way we DON'T need to warn is if we're updating an instance that's already on a "new" (AvailableInSCMU) Rabbit transport
-            var needToWarn = !(isUpgrade && transport.AvailableInSCMU);
-            if (!needToWarn)
+            var newerThan650 = VersionComparer.Version.Compare(instanceVersion, new SemanticVersion(6, 5, 0)) > 0;
+
+            if (isUpgrade && newerThan650)
             {
                 return true;
             }
@@ -166,7 +164,7 @@ public async Task<bool> CanUpgradeInstance(BaseService instance, bool forceUpgra
                 }
             }
 
-            if (!await RabbitMqCheckIsOK(instance.TransportPackage, isUpgrade: true).ConfigureAwait(false))
+            if (!await RabbitMqCheckIsOK(instance.TransportPackage, instance.Version, isUpgrade: true).ConfigureAwait(false))
             {
                 return false;
             }