Apply suggestions from code review

Co-authored-by: Ramon Smits <[email protected]>

Author: andreasohlund

src/ServiceControl.Audit/Auditing/Metrics/BatchMetrics.cs

@@ -12,19 +12,15 @@ public void Dispose()
 
         string result;
 
-        if (actualBatchSize <= 0)
-        {
-            result = "failed";
-            IsSuccess(false);
-        }
-        else
-        {
-            result = actualBatchSize == MaxBatchSize ? "full" : "partial";
+		var isSuccess = actualBatchSize > 0;
+        
+        IsSuccess(isSuccess);
 
-            IsSuccess(true);
+        if (isSuccess)
+        {
+            var result = actualBatchSize == MaxBatchSize ? "full" : "partial";
+            tags.Add("result", result);
         }
-
-        tags.Add("result", result);
         BatchDuration.Record(sw.Elapsed.TotalSeconds, tags);
     }
 

src/ServiceControl.Audit/Auditing/Metrics/IngestionMetrics.cs

@@ -55,7 +55,7 @@ void RecordBatchOutcome(bool success)
         }
     }
 
-    static string CreateInstrumentName(string instrumentName) => $"sc.audit.ingestion.{instrumentName}".ToLower();
+    static string CreateInstrumentName(string instrumentName) => $"sc.audit.ingestion.{instrumentName.ToLower()}";
 
     long consecutiveBatchFailures;