Allow ExpirationProcessTimerInSeconds to be set to 36 hours to improve compatibility with RavenDB cloud.

Author: ramonsmits

src/ServiceControl.Audit.Persistence.RavenDB/RavenPersistenceConfiguration.cs

@@ -142,7 +142,7 @@ static int GetExpirationProcessTimerInSeconds(PersistenceSettings settings)
                 expirationProcessTimerInSeconds = int.Parse(expirationProcessTimerInSecondsString);
             }
 
-            var maxExpirationProcessTimerInSeconds = TimeSpan.FromHours(3).TotalSeconds;
+            var maxExpirationProcessTimerInSeconds = TimeSpan.FromHours(36).TotalSeconds; // Compatibility with RavenDB cloud free license
 
             if (expirationProcessTimerInSeconds < 0)
             {
@@ -156,6 +156,13 @@ static int GetExpirationProcessTimerInSeconds(PersistenceSettings settings)
                 return ExpirationProcessTimerInSecondsDefault;
             }
 
+            var warningThresholdExpirationProcessTimerInSeconds = TimeSpan.FromHours(3).TotalSeconds;
+
+            if (expirationProcessTimerInSeconds > warningThresholdExpirationProcessTimerInSeconds)
+            {
+                Logger.LogError("It is not recommended to set `ExpirationProcessTimerInSeconds` above {WarningThresholdExpirationProcessTimerInSeconds} set ", warningThresholdExpirationProcessTimerInSeconds);
+            }
+
             return expirationProcessTimerInSeconds;
         }