Miscellaneous cleanup and fixes (#4544)

* Remove leftover EnableInstallers calls

* Move InternalsVisibleTo to csproj

* Remove invalid reference to RavenDB system database

Author: bording

src/ServiceControl.Audit.Persistence.RavenDB/InternalsVisibleTo.cs

@@ -33,6 +33,7 @@
 
   <ItemGroup>
     <InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests.RavenDB" />
+    <InternalsVisibleTo Include="ServiceControl.Audit.Persistence.Tests.RavenDB" />
   </ItemGroup>
 
 </Project>

src/ServiceControl.Audit.Persistence.RavenDB/ServiceControl.Audit.Persistence.RavenDB.csproj

@@ -1,7 +1,6 @@
 namespace ServiceControl.Audit.Infrastructure
 {
     using System;
-    using System.Diagnostics;
     using System.Threading;
     using System.Threading.Tasks;
     using Contracts.EndpointControl;
@@ -56,11 +55,6 @@ public static void Configure(Settings.Settings settings, ITransportCustomization
 
             configuration.DefineCriticalErrorAction(onCriticalError);
 
-            if (Environment.UserInteractive && Debugger.IsAttached)
-            {
-                configuration.EnableInstallers();
-            }
-
             configuration.Recoverability().AddUnrecoverableException<UnrecoverableException>();
 
             if (AppEnvironment.RunningInContainer)

src/ServiceControl.Audit/Infrastructure/NServiceBusFactory.cs

@@ -49,4 +49,10 @@
     <Artifact Include="$(OutputPath)" FileExclude="ServiceControl.Audit.dll.config" DirExclude=".logs" DestinationFolder="$(ArtifactsPath)Particular.ServiceControl.Audit" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests" />
+    <InternalsVisibleTo Include="ServiceControl.Audit.AcceptanceTests.RavenDB" />
+    <InternalsVisibleTo Include="ServiceControl.Audit.UnitTests" />
+  </ItemGroup>
+
 </Project>

src/ServiceControl.Audit/InternalsVisibleTo.cs

@@ -56,4 +56,8 @@
     <Resource Include="Resources\**\*.*" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="ServiceControl.Config.Tests" />
+  </ItemGroup>
+
 </Project>

src/ServiceControl.Audit/ServiceControl.Audit.csproj

@@ -36,4 +36,9 @@
     <Artifact Include="$(OutputPath)" FileExclude="ServiceControl.Monitoring.dll.config;nsb*.txt" DirExclude=".logs" DestinationFolder="$(ArtifactsPath)Particular.ServiceControl.Monitoring" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="ServiceControl.Monitoring.AcceptanceTests" />
+    <InternalsVisibleTo Include="ServiceControl.Monitoring.UnitTests" />
+  </ItemGroup>
+
 </Project>