Improvements (#4902)

* avoid array allocations for string split (#4895)

* use char override for string.Join (#4896)

* use concat instead of join (#4897)

* Undo changes to RavenDB indexes

---------

Co-authored-by: Simon Cropp <[email protected]>

Author: bording

src/Particular.LicensingComponent.UnitTests/API/APIApprovals.cs

@@ -39,7 +39,7 @@ public void HttpApiRoutes()
                     return new
                     {
                         MethodSignature = methodSignature,
-                        HttpMethods = string.Join("/", httpMethods),
+                        HttpMethods = string.Join('/', httpMethods),
                         Route = route.Template
                     };
                 })

src/ServiceControl.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Audit.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Audit.UnitTests/API/APIApprovals.cs

@@ -64,7 +64,7 @@ public void HttpApiRoutes()
                     return new
                     {
                         MethodSignature = methodSignature,
-                        HttpMethods = string.Join("/", httpMethods),
+                        HttpMethods = string.Join('/', httpMethods),
                         Route = route.Template
                     };
                 })

src/ServiceControl.Audit/Infrastructure/FullTypeNameOnlyBehavior.cs

@@ -16,7 +16,7 @@ public Task Invoke(IOutgoingPhysicalMessageContext context, Func<IOutgoingPhysic
                 enclosedTypes[i] = enclosedTypes[i].Replace($", {AssemblyFullName}", string.Empty);
             }
 
-            context.Headers[Headers.EnclosedMessageTypes] = string.Join(";", enclosedTypes);
+            context.Headers[Headers.EnclosedMessageTypes] = string.Join(';', enclosedTypes);
 
             return next(context);
         }

src/ServiceControl.Config/Validation/Validations.cs

@@ -177,7 +177,7 @@ public static IRuleBuilderOptions<T, string> MonitoringInstancePortAvailable<T>(
         public static IRuleBuilderOptions<T, string> ValidPath<T>(this IRuleBuilder<T, string> rulebuilder)
         {
             return rulebuilder.Must((t, path) => { return path != null && !path.Intersect(ILLEGAL_PATH_CHARS).Any(); })
-                .WithMessage(string.Format(MSG_ILLEGAL_PATH_CHAR, string.Join(" ", ILLEGAL_PATH_CHARS)));
+                .WithMessage(string.Format(MSG_ILLEGAL_PATH_CHAR, string.Join(' ', ILLEGAL_PATH_CHARS)));
         }
 
         public static IRuleBuilderOptions<T, TProperty> MustNotBeIn<T, TProperty>(this IRuleBuilder<T, TProperty> ruleBuilder, Func<T, IEnumerable<TProperty>> list) where TProperty : class

src/ServiceControl.Monitoring.AcceptanceTests/ConventionEnforcementTests.cs

@@ -20,7 +20,7 @@ public void Ensure_all_tests_derive_from_a_common_base_class()
                 .Where(t => t.BaseType == null || !typeof(NServiceBusAcceptanceTest).IsAssignableFrom(t))
                 .ToList();
 
-            Assert.That(missingBaseClass, Is.Empty, string.Join(",", missingBaseClass));
+            Assert.That(missingBaseClass, Is.Empty, string.Join(',', missingBaseClass));
         }
 
         [Test]
@@ -33,7 +33,7 @@ public void Ensure_all_sagadatas_are_public()
                 .Where(t => typeof(IContainSagaData).IsAssignableFrom(t))
                 .ToList();
 
-            Assert.That(sagaDatas, Is.Empty, string.Join(",", sagaDatas));
+            Assert.That(sagaDatas, Is.Empty, string.Join(',', sagaDatas));
         }
 
         static bool HasTestMethod(Type t)

src/ServiceControl.Monitoring.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);

src/ServiceControl.Monitoring.UnitTests/API/APIApprovals.cs

@@ -41,7 +41,7 @@ public void HttpApiRoutes()
                 return new
                 {
                     MethodSignature = methodSignature,
-                    HttpMethods = string.Join("/", httpMethods),
+                    HttpMethods = string.Join('/', httpMethods),
                     Route = route.Template
                 };
             })

src/ServiceControl.MultiInstance.AcceptanceTests/TestSupport/SelfVerification/EndpointNameEnforcementTests.cs

@@ -21,7 +21,7 @@ public void EndpointName_should_not_exceed_maximum_length()
                 .Where(t => Conventions.EndpointNamingConvention(t).Length > endpointNameMaxLength)
                 .ToList();
 
-            Assert.That(violators, Is.Empty, string.Join(",", violators));
+            Assert.That(violators, Is.Empty, string.Join(',', violators));
         }
 
         static bool IsEndpointClass(Type t) => endpointConfigurationBuilderType.IsAssignableFrom(t);