default to nLog

PhilBastian · PhilBastian · commit c3c3de47ad29 · 2025-06-19T09:26:19.000+08:00
diff --git a/src/ServiceControl.Infrastructure/LoggingSettings.cs b/src/ServiceControl.Infrastructure/LoggingSettings.cs
@@ -24,7 +24,8 @@ public LoggingSettings(SettingsRootNamespace rootNamespace, LogLevel defaultLeve
         {
             activeLoggers |= Loggers.Seq;
         }
-        LoggerUtil.ActiveLoggers = activeLoggers;
+        //this defaults to NLog because historically that was the default, and we don't want to break existing installs that don't have the config key to define loggingProviders
+        LoggerUtil.ActiveLoggers = activeLoggers == Loggers.None ? Loggers.NLog : activeLoggers;
     }
 
     public LogLevel LogLevel { get; }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,8 @@ public LoggingSettings(SettingsRootNamespace rootNamespace, LogLevel defaultLeve`
`24`	`24`	`{`
`25`	`25`	`activeLoggers \|= Loggers.Seq;`
`26`	`26`	`}`
`27`		`- LoggerUtil.ActiveLoggers = activeLoggers;`
	`27`	`+ //this defaults to NLog because historically that was the default, and we don't want to break existing installs that don't have the config key to define loggingProviders`
	`28`	`+ LoggerUtil.ActiveLoggers = activeLoggers == Loggers.None ? Loggers.NLog : activeLoggers;`
`28`	`29`	`}`
`29`	`30`
`30`	`31`	`public LogLevel LogLevel { get; }`